Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix width and height of cc button #4560

Closed
wants to merge 1 commit into from
Closed

Conversation

mugendin
Copy link

@mugendin mugendin commented Aug 10, 2017

add as proposed 100% width and height and reorder css properties according to https://css-tricks.com/poll-results-how-do-you-order-your-css-properties/ fixies issue #4547

Description

Bug fix of issue #4547
Add width 100% and height 100%
also change styles order in button.scss as in https://css-tricks.com/poll-results-how-do-you-order-your-css-properties/

Issue:
#4547

Requirements Checklist

  • [ 1] Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • [ 1] Change has been verified in an actual browser (Chome, Firefox, IE)
      Tested in Chrome and Firefox
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

add as proposed 100% width and height and reorder css properties according to https://css-tricks.com/poll-results-how-do-you-order-your-css-properties/ fixies issue videojs#4547
@gkatsev
Copy link
Member

gkatsev commented Aug 10, 2017

Thanks. Unfortunately, this will cause issues for buttons that aren't in inside of a vjs-control. For example, buttons in the captions settings dialog
screen shot 2017-08-10 at 15 16 40.

This has already been fixed by #4548.

@gkatsev gkatsev closed this Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants