Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Subs caps button size issue #4548

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Fix: Subs caps button size issue #4548

merged 1 commit into from
Aug 10, 2017

Conversation

Kishan08
Copy link
Contributor

@Kishan08 Kishan08 commented Aug 8, 2017

Fix the subs caps button size issue (#4547)

@gkatsev
Copy link
Member

gkatsev commented Aug 9, 2017

Thanks @Kishan08.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Kishan08
Copy link
Contributor Author

Can you merge this pull request?
Thanks for approving it.

@gkatsev
Copy link
Member

gkatsev commented Aug 10, 2017

Yup, we tend to merge in waves. Though, probably should merge as early as possible.

@gkatsev gkatsev mentioned this pull request Aug 10, 2017
5 tasks
@gkatsev gkatsev merged commit cd2f510 into videojs:master Aug 10, 2017
atefBB pushed a commit to atefBB/video.js that referenced this pull request Aug 16, 2017
…deojs#4548)

Add a width and height property of 100% to `.vjs-control .vjs-button` selector.

Fixes videojs#4547.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants