fix: only change focus from BPB if not a mouse click #4523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/js/big-play-button.js
Outdated
| if (playPromise) { | ||
| playPromise.then(() => playToggle.focus()); | ||
| } else { | ||
| this.setTimeout(function() { |
There was a problem hiding this comment.
maybe store this function since it is used above? or just use the shorthand again?
There was a problem hiding this comment.
yeah, might make sense. Ported this from master where it's written this way.
src/js/big-play-button.js
Outdated
| this.setTimeout(function() { | ||
| playToggle.focus(); | ||
| }, 1); | ||
| if (playPromise) { |
There was a problem hiding this comment.
Should this duck-type the play promise (e.g. if (playPromise && playPromise.then) {)?
There was a problem hiding this comment.
This was ported over from master, it's probably safer
brandonocasey
approved these changes
Jul 26, 2017
misteroneill
approved these changes
Jul 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.x version of #4497