-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iphone/Ipad - safari, embed video gets page scrolled down on play event #4626
Comments
i was trying new version, the bug is still here, this happens not only when you click on 'big play button', but also just when the 'play' event is triggered. As i researched a lot about,i found that iOS on iPhone and iPad has a specific thing which fixes the position of the player on "center" on the window, when the 'play' event is triggered, the same thing happens in pure html5 player too. to fix this, i found that there on the body,html should be 3 css parameters
This fixes the issue, but for the 'height:100%', it breaks down another things on the site. i've created an example with 5.20.4, test it here |
i've tested pure html5 player in the same way, and tested other players,for example 'vimeo' player and there's no bug like this,i thought it was something by default for that OS, but not, there's some bug exactly in VideoJS. So i tried to fix this myself, i found that by deleting this.trigger('play') then when you play the video, video initiates to play, and there's no scroll jumping anymore, but events you have set, doesn't work anymore.
|
Description
We have a page with iframes of videojs included in,
On Iphone or Ipad, using Safari browser, when you tap on "play" button, the page gets scrolled down.
For example tested here http://elemb.com/projects/yaplakal/html5player/dist/app/tests/demo.php
And here http://bestof.interactr.io/
Steps to reproduce
Results
Expected
The page shouldn't be scrolled down.
Actual
The page gets scrolled down on first play event.
Error output
No console errors.
Additional Information
versions
videojs
I guess the version doesn't matter at all, as this issue was tested on 5.13.0 and 5.18.4, same bug on both.
browsers
Safari
OSes
iOS
The text was updated successfully, but these errors were encountered: