fix: auto-removal remote text tracks being removed when not supposed to #4434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misteroneill
previously requested changes
Jun 23, 2017
test/unit/tracks/text-tracks.test.js
Outdated
| techOrder: ['html5'] | ||
| }); | ||
|
|
||
| console.log(player.isReady_, player.tech_.isReady_); |
There was a problem hiding this comment.
Linter is complaining about this.
test/unit/tracks/text-tracks.test.js
Outdated
| techOrder: ['html5'] | ||
| }); | ||
|
|
||
| console.log(player.isReady_, player.tech_.isReady_); |
There was a problem hiding this comment.
Linter is complaining about this.
misteroneill
approved these changes
Jun 23, 2017
|
Closing this PR for the moment so I can re-open it via upstream so tests will run against browserstack. |
|
New PR: #4450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We added a feature so that remote text tracks can auto-removed when a source changes. However, in 6.x we changed the source behavior to be asynchronous meaning that some text tracks were accidentally being removed when they weren't supposed to be.
For example:
Now when the player loads, this captions track is actually missing because it was removed.
Specific Changes proposed
Instead of adding auto-removal tracks immediately to the list, wait until we've selected a source before adding them in.
This probably needs a test.
Fixes #4403 and #4315.