-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting TextTrack to defaults not working when text track and video player are created dynamically. #4315
Comments
…to (#4450) We added a feature so that remote text tracks can auto-removed when a source changes. However, in 6.x we changed the source behavior to be asynchronous meaning that some text tracks were accidentally being removed when they weren't supposed to be. For example: ```js var player = videojs('my-player'); player.src({src: 'video.mp4', type: 'video/mp4'}); // set second arg to false so that they get auto-removed on source change player.addRemoteTextTrack({kind: 'captions', src: 'text.vtt', srclang: 'en'}, false); ``` Now when the player loads, this captions track is actually missing because it was removed. Instead of adding auto-removal tracks immediately to the list, wait until we've selected a source before adding them in. Fixes #4403 and #4315.
Closing as potentially fixed and due to lack of activity. If we get more information, we can re-open. |
I am having this problem with version 6.6.2. Actually, I have the video and a default track loaded initially with HTML tags, and the track is selected by default...this works fine. The page implements a very rudimentary subtitle editor...for now, any time a cue is edited, it deletes the entire TextTrack and reloads it using The documentation is not clear as to how to activate a loaded TextTrack from Javascript, other than setting |
I just spent a while stepping through with devtools... it looks like the property that is affected by selecting the text track from the menu is So, if I pass the option ...I'm actually seeing the |
@partap Thanks man. |
Description
I wan't to create a dynamic video player i.e. video src and caption src comes from different file on click event.
Steps to reproduce
Explain in detail the exact steps necessary to reproduce the issue.
Here is the code that I have used.
Results
Expected
I Expect to see subtitles when video is loaded.
Actual
When Video is loaded subtitles are off.
The text was updated successfully, but these errors were encountered: