Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore options/players Globals #2395

Closed
wants to merge 7 commits into from
Closed

Restore options/players Globals #2395

wants to merge 7 commits into from

Commits on Jul 24, 2015

  1. Re-expose globals for backward compatibility.

    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    beb9c4c View commit details
    Browse the repository at this point in the history

  2. Use Proxy objects if possible.

    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    fb467d1 View commit details
    Browse the repository at this point in the history

  3. Implement customized messages for deprecation Proxies.

    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    90d82cf View commit details
    Browse the repository at this point in the history

  4. Add tests for options/players maybe-proxy objects.

    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    03716e8 View commit details
    Browse the repository at this point in the history

  5. Proxy handler set must return a Boolean. 

    Also, add a test for the set case.
    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    4df75ae View commit details
    Browse the repository at this point in the history

  6. Move createDeprecationProxy to util.

    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    17c1983 View commit details
    Browse the repository at this point in the history

  7. Capitalize deprecation warnings.

    @misteroneill
    misteroneill committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    0465c04 View commit details
    Browse the repository at this point in the history