Restore options/players Globals

[misteroneill]

Addresses #2311.

This restores the options and players properties of videojs.

Browsers with Proxy support (Firefox and IE Edge at the moment) will additionally log a warning on both get/set operations only through these specific properties. That is, modifying videojs.players will log a deprecation warning where internal modifications to Player.players will not.

Both cases - using Proxy and not - are tested.

[gkatsev]

can we have this return either the proxy or just the target?
Then below in your usage we could do

videojs.players = createDeprecationProxy(Players.players, {
  get: 'access to videojs.players is deprecated; use videojs.getPlayers instead',
  set: 'modification of videojs.players is deprecated'
});

Also, we should consider putting this function into its own file in src/utils/ so that others could possibly use it as well.

[misteroneill]

👍 on both.

The name argument is a holdover from the original implementation, which generated the log messages. Since that doesn't happen anymore, it's superfluous and your suggestion is better!

[misteroneill]

Moved createDeprecationProxy into a module and changed its signature a bit (removing the name argument).

[gkatsev]

LGTM

[mmcc]

@pam retry

[mmcc]

@pam retry

[heff]

Nit-picky but I'd prefer the warning messages to have a capital first letter.

Looks good to me.

[misteroneill]

@heff Sounds good (and done).