Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time display for player causes prevention role conflict accessibility issue #8143

Open
bwood614 opened this issue Feb 20, 2023 · 2 comments
Open
Labels
bug needs: triage This issue needs to be reviewed

Comments

@bwood614
Copy link

Description

The time display elements in the player have an accessibility issue. The elements within the various time display elements (e.g. spans with classes like vjs-current-time-display, vjs-duration-display, vjs-remaining-time-display, etc.) have the attributes role="presentation" and aria-live="off". It looks like role="presentation" was added some time after the aria-live attribute and the aria-live attribute was never removed.

Having global aria attributes and role="presentation" in the same element is redundant and can lead to some unexpected behaviors across browsers. See https://dequeuniversity.com/rules/axe/4.1/presentation-role-conflict for more information about this issue.

Reduced test case

No response

Steps to reproduce

  1. Inspect the time display element(s) in the player with browser dev tools

Errors

No response

What version of Video.js are you using?

8.0.4

Video.js plugins used.

None

What browser(s) including version(s) does this occur with?

Chrome 109

What OS(es) and version(s) does this occur with?

Mac OS Monterey v12.4

@bwood614 bwood614 added bug needs: triage This issue needs to be reviewed labels Feb 20, 2023
@welcome
Copy link

welcome bot commented Feb 20, 2023

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@brayden-wood
Copy link
Contributor

I am picking up this issue and submitting a PR for it

brayden-wood added a commit to cvent/video.js that referenced this issue Mar 8, 2023
This change is to remove the aria-live attribute from time display elements. The aria-live attribute is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior.
Fixes issue videojs#8143
misteroneill pushed a commit that referenced this issue Mar 21, 2023
This change is to remove the aria-live attribute from time display elements. The aria-live attribute is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior.
Fixes issue #8143
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
This change is to remove the aria-live attribute from time display elements. The aria-live attribute is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior.
Fixes issue videojs#8143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants