Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved accessibility for time display #8144

Closed
wants to merge 1 commit into from

Conversation

bwood614
Copy link

This change is to remove the aria-live attribute from time display elements. aria-live is no longer needed since the presentation role was added. Both attributes being present can lead to unexpected screen reader behavior.

Description

Bug issue: #8143

Specific Changes proposed

  • Remove aria-live="off" from all time display elements within the player since they already have role="presentation"

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

This change is to remove the aria-live attribute from time display elements.
aria-live is no longer needed since the presentation role was added.
Both attributes being present can lead to unexpected screen reader behavior.
@welcome
Copy link

welcome bot commented Feb 20, 2023

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@Yie3
Copy link

Yie3 commented Feb 21, 2023

@

@bwood614 bwood614 closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants