Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to hide pip when fullscreen ? #7921

Closed
febrimaulana opened this issue Sep 9, 2022 · 7 comments
Closed

how to hide pip when fullscreen ? #7921

febrimaulana opened this issue Sep 9, 2022 · 7 comments

Comments

@febrimaulana
Copy link

febrimaulana commented Sep 9, 2022

Description

how to hide pip when fullscreen ?
image

Reduced test case

No response

Steps to reproduce

  1. click pip on video
  2. click fullscreen on the video while pip is still active

What version of Video.js are you using?

v7.20.1

Video.js plugins used.

https://vjs.zencdn.net/7.20.1/video.min.js

What browser(s) including version(s) does this occur with?

chrome

@febrimaulana febrimaulana added bug needs: triage This issue needs to be reviewed labels Sep 9, 2022
@welcome
Copy link

welcome bot commented Sep 9, 2022

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mister-ben
Copy link
Contributor

You can exit pip when entering fullscreen like this

player.on('fullscreenchange', function() {
    if (player.isFullscreen() && player.isInPictureInPicture()) {
        player.exitPictureInPicture();
    }
});

@mister-ben mister-ben added good first issue and removed needs: triage This issue needs to be reviewed labels Sep 22, 2022
@mister-ben
Copy link
Contributor

This should be a default behaviour, a native video element will exit PIP on entering fullscreen

@Walexero
Copy link

Is anyone interested in working on the issue, if not, i would be interested on working on it and would also need guidance on how to go about it

ThorTJ added a commit to ThorTJ/video.js that referenced this issue Oct 2, 2022
Picture in Picture remains open if entering fullscreen. This disables Picture in Picture when entering fullscreen.

Closes videojs#7921
@onigetoc
Copy link

For myself, I also want to remove/hide pip on mobile, it do nothing except on my tablet where the video view disappear and is not showing anywhere.

@lalitkumawat1m
Copy link

I want to work on this issue could you please assign to me ?

@mister-ben
Copy link
Contributor

Thanks, but this should have been closed when this was fixed in #8082. The player now exits fillscreen when entering PIP mode, and exits PIP when going fullscreen.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants