-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
how to hide pip when fullscreen ? #7921
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
You can exit pip when entering fullscreen like this player.on('fullscreenchange', function() {
if (player.isFullscreen() && player.isInPictureInPicture()) {
player.exitPictureInPicture();
}
}); |
This should be a default behaviour, a native video element will exit PIP on entering fullscreen |
Is anyone interested in working on the issue, if not, i would be interested on working on it and would also need guidance on how to go about it |
Picture in Picture remains open if entering fullscreen. This disables Picture in Picture when entering fullscreen. Closes videojs#7921
For myself, I also want to remove/hide pip on mobile, it do nothing except on my tablet where the video view disappear and is not showing anywhere. |
I want to work on this issue could you please assign to me ? |
Thanks, but this should have been closed when this was fixed in #8082. The player now exits fillscreen when entering PIP mode, and exits PIP when going fullscreen. |
Description
how to hide pip when fullscreen ?
Reduced test case
No response
Steps to reproduce
What version of Video.js are you using?
v7.20.1
Video.js plugins used.
https://vjs.zencdn.net/7.20.1/video.min.js
What browser(s) including version(s) does this occur with?
chrome
The text was updated successfully, but these errors were encountered: