-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exit PIP if entering fullscreen #8082
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## main #8082 +/- ##
==========================================
+ Coverage 81.91% 81.97% +0.06%
==========================================
Files 110 110
Lines 7342 7341 -1
Branches 1772 1771 -1
==========================================
+ Hits 6014 6018 +4
+ Misses 1328 1323 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, although a test would be nice.
Congrats on merging your first pull request! 🎉🎉🎉 |
* exit PIP if entering fullscreen * assert that entering full screen leaves PiP
Description
Updates video.js to exit PiP when requesting fullscreen per this issue.
Specific Changes proposed
requestFullscreen
forisInPictureInPicture
, callingexitPictureInPicture
if so.Should more be done here?
Requirements Checklist