Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Autoplay blog link in FAQ leads to 404 #6905

Closed
aminamos opened this issue Oct 20, 2020 · 6 comments · Fixed by #7027
Closed

docs: Autoplay blog link in FAQ leads to 404 #6905

aminamos opened this issue Oct 20, 2020 · 6 comments · Fixed by #7027

Comments

@aminamos
Copy link
Contributor

Description

The autoplay blog hyperlink under the "Q: How do I autoplay a video?" section of the FAQ leads to an error page.

Expected link: https://videojs.com/blog/autoplay-best-practices-with-video-js/
Current link: https://docs.videojs.com/%5C/%5C/blog.videojs.com/autoplay-best-practices-with-video-js/

Steps to reproduce

  1. Navigate to the FAQ section: https://docs.videojs.com/tutorial-faq.html#q%3A-how-do-i-autoplay-a-video%3F
  2. In the last line of that section, click the link

Results

Expected

Autoplay blog is available.

Actual

404 page not found error.

Error output

404

@welcome
Copy link

welcome bot commented Oct 20, 2020

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Dec 25, 2020
@gkatsev
Copy link
Member

gkatsev commented Jan 5, 2021

My assumption is that our fix link script is misunderstanding this url and editing it unnecessarily.

@stale stale bot removed the outdated Things closed automatically by stalebot label Jan 5, 2021
@gkatsev
Copy link
Member

gkatsev commented Jan 5, 2021

Actually, looks like jsdoc or something is translating the url badly. It's coming out as https:%5C/%5C/videojs.com/blog/autoplay-best-practices-with-video-js/ with those %5C for some reason. Sounds like some weird escape issue in jsdoc or something.

@gkatsev
Copy link
Member

gkatsev commented Jan 5, 2021

Not sure what's up with jsdoc's linkification. Made this as a workaround: #7027

@aminamos
Copy link
Contributor Author

aminamos commented Jan 6, 2021

Thank you!

gkatsev added a commit that referenced this issue Jan 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2022
edirub pushed a commit to edirub/video.js that referenced this issue Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants