Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken blogpost urls #7106

Merged
merged 1 commit into from
Feb 22, 2021
Merged

Conversation

FredZeng
Copy link
Contributor

Description

  1. can't access current link https://github.com/videojs/generator-videojs-plugin/blob/main/docs/standards.md in plugins.md since it has changed to https://github.com/videojs/generator-videojs-plugin/blob/master/docs/conventions.md
  2. links in faq.md and options.md have same problem as #6905

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Feb 22, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev merged commit dd0c675 into videojs:main Feb 22, 2021
@welcome
Copy link

welcome bot commented Feb 22, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@gkatsev
Copy link
Member

gkatsev commented Feb 22, 2021

Thanks!

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants