-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate proper number of segments for multiperiod content that uses segment template #138
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,199 @@ | ||
| export const parsedManifest = { | ||
| allowCache: true, | ||
| uri: '', | ||
| duration: 30, | ||
| discontinuityStarts: [], | ||
| segments: [], | ||
| endList: true, | ||
| mediaGroups: { | ||
| 'AUDIO': { | ||
| audio: { | ||
| en: { | ||
| language: 'en', | ||
| autoselect: true, | ||
| default: true, | ||
| playlists: [ | ||
| { | ||
| attributes: { | ||
| 'NAME': '2', | ||
| 'BANDWIDTH': 32000, | ||
| 'CODECS': 'mp4a.40.2', | ||
| 'PROGRAM-ID': 1 | ||
| }, | ||
| uri: '', | ||
| endList: true, | ||
| timeline: 1, | ||
| resolvedUri: '', | ||
| targetDuration: 5, | ||
| segments: [ | ||
| { | ||
| uri: 'audio/segment_0.m4f', | ||
| timeline: 1, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/audio/segment_0.m4f', | ||
| map: { | ||
| uri: 'audio/init.m4f', | ||
| resolvedUri: 'https://www.example.com/audio/init.m4f' | ||
| }, | ||
| number: 0 | ||
| }, | ||
| { | ||
| uri: 'audio/segment_1.m4f', | ||
| timeline: 1, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/audio/segment_1.m4f', | ||
| map: { | ||
| uri: 'audio/init.m4f', | ||
| resolvedUri: 'https://www.example.com/audio/init.m4f' | ||
| }, | ||
| number: 1 | ||
| }, | ||
| { | ||
| uri: 'audio/segment_2.m4f', | ||
| timeline: 1, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/audio/segment_2.m4f', | ||
| map: { | ||
| uri: 'audio/init.m4f', | ||
| resolvedUri: 'https://www.example.com/audio/init.m4f' | ||
| }, | ||
| number: 2 | ||
| }, | ||
| { | ||
| discontinuity: true, | ||
| uri: 'audio/segment_0.m4f', | ||
| timeline: 2, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/audio/segment_0.m4f', | ||
| map: { | ||
| uri: 'audio/init.m4f', | ||
| resolvedUri: 'https://www.example.com/audio/init.m4f' | ||
| }, | ||
| number: 0 | ||
| }, | ||
| { | ||
| uri: 'audio/segment_1.m4f', | ||
| timeline: 2, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/audio/segment_1.m4f', | ||
| map: { | ||
| uri: 'audio/init.m4f', | ||
| resolvedUri: 'https://www.example.com/audio/init.m4f' | ||
| }, | ||
| number: 1 | ||
| }, | ||
| { | ||
| uri: 'audio/segment_2.m4f', | ||
| timeline: 2, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/audio/segment_2.m4f', | ||
| map: { | ||
| uri: 'audio/init.m4f', | ||
| resolvedUri: 'https://www.example.com/audio/init.m4f' | ||
| }, | ||
| number: 2 | ||
| } | ||
| ], | ||
| mediaSequence: 0 | ||
| } | ||
| ], | ||
| uri: '' | ||
| } | ||
| } | ||
| }, | ||
| 'VIDEO': {}, | ||
| 'CLOSED-CAPTIONS': {}, | ||
| 'SUBTITLES': {} | ||
| }, | ||
| playlists: [ | ||
| { | ||
| attributes: { | ||
| 'NAME': '1', | ||
| 'AUDIO': 'audio', | ||
| 'SUBTITLES': 'subs', | ||
| 'RESOLUTION': { | ||
| width: 480, | ||
| height: 200 | ||
| }, | ||
| 'CODECS': 'avc1.4d001f', | ||
| 'BANDWIDTH': 100000, | ||
| 'PROGRAM-ID': 1 | ||
| }, | ||
| uri: '', | ||
| endList: true, | ||
| timeline: 1, | ||
| resolvedUri: '', | ||
| targetDuration: 5, | ||
| segments: [ | ||
| { | ||
| uri: 'video/segment_0.m4f', | ||
| timeline: 1, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/video/segment_0.m4f', | ||
| map: { | ||
| uri: 'video/init.m4f', | ||
| resolvedUri: 'https://www.example.com/video/init.m4f' | ||
| }, | ||
| number: 0 | ||
| }, | ||
| { | ||
| uri: 'video/segment_1.m4f', | ||
| timeline: 1, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/video/segment_1.m4f', | ||
| map: { | ||
| uri: 'video/init.m4f', | ||
| resolvedUri: 'https://www.example.com/video/init.m4f' | ||
| }, | ||
| number: 1 | ||
| }, | ||
| { | ||
| uri: 'video/segment_2.m4f', | ||
| timeline: 1, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/video/segment_2.m4f', | ||
| map: { | ||
| uri: 'video/init.m4f', | ||
| resolvedUri: 'https://www.example.com/video/init.m4f' | ||
| }, | ||
| number: 2 | ||
| }, | ||
| { | ||
| discontinuity: true, | ||
| uri: 'video/segment_0.m4f', | ||
| timeline: 2, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/video/segment_0.m4f', | ||
| map: { | ||
| uri: 'video/init.m4f', | ||
| resolvedUri: 'https://www.example.com/video/init.m4f' | ||
| }, | ||
| number: 0 | ||
| }, | ||
| { | ||
| uri: 'video/segment_1.m4f', | ||
| timeline: 2, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/video/segment_1.m4f', | ||
| map: { | ||
| uri: 'video/init.m4f', | ||
| resolvedUri: 'https://www.example.com/video/init.m4f' | ||
| }, | ||
| number: 1 | ||
| }, | ||
| { | ||
| uri: 'video/segment_2.m4f', | ||
| timeline: 2, | ||
| duration: 5, | ||
| resolvedUri: 'https://www.example.com/video/segment_2.m4f', | ||
| map: { | ||
| uri: 'video/init.m4f', | ||
| resolvedUri: 'https://www.example.com/video/init.m4f' | ||
| }, | ||
| number: 2 | ||
| } | ||
| ], | ||
| mediaSequence: 0 | ||
| } | ||
| ] | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and below, the duration of the period exceeded the
mediaPresentationDuration, so removed the period duration to fix the manifests (they were breaking the tests after this change).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still have tests with period duration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In inheritAttributes I just added one recently! https://github.com/videojs/mpd-parser/blob/main/test/inheritAttributes.test.js#L675
And for segment generation I added https://github.com/videojs/mpd-parser/pull/138/files#diff-fcc9322a475e1685d979ab8e7c8da4736e1653a4613e5459ded4b47e8440edc8R1516
For end-to-end I don't believe we have any right now. I can add one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah might be good to add one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 added