fix: generate proper number of segments for multiperiod content that uses segment template #138
Conversation
…uses segment template
| @@ -1370,7 +1374,7 @@ QUnit.test( | |||
| const actual = toPlaylists(inheritAttributes(stringToMpdXml(` | |||
| <MPD mediaPresentationDuration= "PT30S" > | |||
| <BaseURL>https://www.example.com/base</BaseURL> | |||
| <Period duration= "PT0H4M40.414S" > | |||
| <Period> | |||
There was a problem hiding this comment.
Here and below, the duration of the period exceeded the mediaPresentationDuration, so removed the period duration to fix the manifests (they were breaking the tests after this change).
There was a problem hiding this comment.
Do we still have tests with period duration?
There was a problem hiding this comment.
In inheritAttributes I just added one recently! https://github.com/videojs/mpd-parser/blob/main/test/inheritAttributes.test.js#L675
And for segment generation I added https://github.com/videojs/mpd-parser/pull/138/files#diff-fcc9322a475e1685d979ab8e7c8da4736e1653a4613e5459ded4b47e8440edc8R1516
For end-to-end I don't believe we have any right now. I can add one.
There was a problem hiding this comment.
Yeah might be good to add one.
No description provided.