Fix missing details if subtitle changed synchronously after loaded and before onLoaded callback #6424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d before onLoaded callback
robwalch
approved these changes
May 17, 2024
robwalch
added a commit
that referenced
this pull request
May 31, 2024
* patch/v1.5.x: Update github actions chore(deps): update tjenkinson/gh-action-auto-merge-dependency-updates action to v1.4.2 (#6333) Emit FRAG_PARSING_ERROR on unsupported M2TS codec (#6447) Fix JS AES fallback when browserCrypto.subtle returns undefined (rather than null) (#6446) Fix 608 caption TextTrack Cue seek/discontinuity timing regression introduced in v1.5.0 with #5557 Fix 608 parser handling of redundant control codes Fixes #6427 Fix backtracking when an appended segment has no buffered timerange (#6434) Fix missing details if subtitle changed synchronously after loaded and before onLoaded callback (#6424) Bugfix: Handle irregular white-space in segment URIs (#6396)
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix issue where changing subtitle before onLoaded is called drops the details from the track
Why is this Pull Request needed?
Resolves #6402
Are there any points in the code the reviewer needs to double check?
Resolves issues:
#6402
Checklist