Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Handle irregular white-space in segment URIs #6396

Merged
merged 3 commits into from
May 4, 2024
Merged

Bugfix: Handle irregular white-space in segment URIs #6396

merged 3 commits into from
May 4, 2024

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented May 3, 2024 •
edited
Loading

This PR will...

  • Update parser pattern to not terminate segment URIs on irregular white-space
  • Add test for unicode (\u3000) white-space in segment URIs

Why is this Pull Request needed?

Someone put \u3000 chars in their segment URIs and the regular expression to match segment URIs ends on any white-space character instead of only newline or return like the pattern used for media playlist URIs.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #6381

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch changed the title Bugfix/parser unicode ws Bugfix: Handle irregular white-space in segment URIs May 3, 2024
@robwalch robwalch added this to the 1.6.0 milestone May 3, 2024
@robwalch robwalch mentioned this pull request May 3, 2024
Closed
5 tasks
@robwalch robwalch enabled auto-merge (squash) May 4, 2024 15:00
@robwalch robwalch disabled auto-merge May 4, 2024 15:00
@robwalch robwalch requested a review from iamboorrito May 4, 2024 15:01
@robwalch robwalch enabled auto-merge (squash) May 4, 2024 15:01
@robwalch robwalch merged commit 542e75f into master May 4, 2024
16 checks passed
@robwalch robwalch deleted the bugfix/parser-unicode-ws branch May 4, 2024 22:34
robwalch added a commit that referenced this pull request May 15, 2024
@robwalch
Bugfix: Handle irregular white-space in segment URIs (#6396)
0ab4aa4 
* Update parser pattern to not terminate segment URLs on unicode white-space
Fixes #6381

* Add test for irregular white-space in segment URIs

(cherry picked from commit 542e75f)
@robwalch robwalch modified the milestones: 1.6.0, 1.5.9 May 23, 2024
robwalch added a commit that referenced this pull request May 31, 2024
@robwalch
Merge branch 'patch/v1.5.x'
1b7cb22 
* patch/v1.5.x:
  Update github actions
  chore(deps): update tjenkinson/gh-action-auto-merge-dependency-updates action to v1.4.2 (#6333)
  Emit FRAG_PARSING_ERROR on unsupported M2TS codec (#6447)
  Fix JS AES fallback when browserCrypto.subtle returns undefined (rather than null) (#6446)
  Fix 608 caption TextTrack Cue seek/discontinuity timing regression introduced in v1.5.0 with #5557
  Fix 608 parser handling of redundant control codes Fixes #6427
  Fix backtracking when an appended segment has no buffered timerange (#6434)
  Fix missing details if subtitle changed synchronously after loaded and before onLoaded callback (#6424)
  Bugfix: Handle irregular white-space in segment URIs (#6396)
This was referenced Aug 6, 2024
Merged
Merged
@tachibana-shin tachibana-shin mentioned this pull request Aug 22, 2024
Open
@Tisankan Tisankan mentioned this pull request Sep 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamboorrito iamboorrito iamboorrito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.9
Development

Successfully merging this pull request may close these issues.

HLS fails to stream video with name containing U+3000 character.
2 participants
@robwalch @iamboorrito