Use named exports in ESM output

[robwalch]

This PR will...

Include named exports in ESM output for classes and enums in addition to the default export.

Why is this Pull Request needed?

Allows import and use of classes and enums in the public API with ESM output. UMD output continues to use default Hls class export only for backwards compatibility.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #5630

Checklist

• changes have been done against master branch, and PR does not conflict
• new unit / functional tests have been added (whenever applicable)
• API or design changes are documented in API.md

[ferferga]

@robwalch With this, npm run build:ci passes locally. I also replaced the dist folder into the node_modules/hls.js/dist folder of my project jellyfin-vue.

By changing this line: https://github.com/jellyfin/jellyfin-vue/blob/master/frontend/src/components/Playback/PlayerElement.vue#L33 to:

import Hls, { ErrorData, Events, ErrorTypes } from 'hls.js';

and fixing all the linter errors reported in that file, my project build without any issues,.

So doing this change is indeed the only required thing to be fully backwards-compatible.

Suggested change

	export {
	Hls,
	export default Hls;
	export {
	Hls,

[ferferga]

By the way, you can quickly test this in my project with GH Codespaces, since we have first-class support for devcontainers.

"Code" button at the right corner > Create Codespace

Just cd into the frontend directory and run npm run build to build. Go to the previously mentioned file where hls.js is imported and do the relevant tests.

[robwalch]

Fantastic! The mixed named and default exports was only a problem with the UMD output which we've given it's own target so it remains unchanged. So happy that the ESM output does not make the default export an object * with a default property.

[robwalch]

@cjpillsbury @littlespex when you have a chance, please file an issue re: composing player features/controllers.

The rough idea we discussed at day 1 of Demuxed is to have a constructor that required import and passing in of the controllers that handle the features you need, and 🤞 let tree-shaking handle removal of the ones you do not for a smaller footprint.

A good POC would need to replace most of the build constants we use today to define the light output with new entry files.

[ferferga]

@robwalch When this gets merged, it'd be great if a patch release can be made 😊.

Thank you very much again!

[ferferga]

Why?

Besides, maybe this should go into another PR so we have this isolated in case of issues.

[robwalch]

reversed

[ferferga]

LGTM! 🚀🚀

[ferferga]

@robwalch I believe the failing test is completely unrelated to this? Maybe a rebase against master could fix it?

[robwalch]

@robwalch I believe the failing test is completely unrelated to this? Maybe a rebase against master could fix it?

The test failure is a known issue in older versions of Safari.