Missing "./src/is-supported" specifier in "hls.js" package. (svelte, vite)

[jer-0]

What version of Hls.js are you using?

v1.4.6

What browser (including version) are you using?

chrome 111

What OS (including version) are you using?

windows 11

Test stream

No response

Configuration

{}

Additional player setup steps

No response

Checklist

• The issue observed is not already reported by searching on Github under https://github.com/video-dev/hls.js/issues
• The issue occurs in the stable client (latest release) on https://hlsjs.video-dev.org/demo and not just on my page
• The issue occurs in the latest client (main branch) on https://hlsjs-dev.video-dev.org/demo and not just on my page
• The stream has correct Access-Control-Allow-Origin headers (CORS)
• There are no network errors such as 404s in the browser console when trying to play the stream

Steps to reproduce

https://stackblitz.com/edit/vitejs-vite-stkzfz?file=src%2FApp.svelte

Expected behaviour

should not error

What actually happened?

Hello, since version 1.4.0 importing isSupported from hls.js/src/is-supported throws an error from vite.

use case:
isSupported function is bundled with my app and hls.js is dynamically imported if media source is supported, so to not increase my app bundle size if hls.js is not needed.

Thanks.

Console output

Missing "./src/is-supported" specifier in "hls.js" package
10:52:43 PM [vite] Internal server error: Missing "./src/is-supported" specifier in "hls.js" package
  Plugin: vite:import-analysis
  File: /home/projects/vitejs-vite-stkzfz/src/App.svelte

Chrome media internals output

No response

[nostrorom]

Having the same issue :)

[robwalch]

The src directory is not part of the distributed package files. isSupported is a static method on the default export, so you can just as well do import { isSupported } from 'hls.js' without any error.

[jer-0]

The src directory is not part of the distributed package files. isSupported is a static method on the default export, so you can just as well do import { isSupported } from 'hls.js' without any error.

That doesn't work

Module '"hls.js"' has no exported member 'isSupported'. Did you mean to use 'import isSupported from "hls.js"' instead?

I believe what you mean is this:

import Hls from 'hls.js'
const { isSupported } = Hls

[robwalch]

I believe what you mean is this:

import Hls from 'hls.js'
const { isSupported } = Hls

Correct, 1.4 defines "hls.js" as an ESM module with a default export of the Hls class.

[robwalch]

We're also stuck on #5685 for the similar reasons. Users are trying to perform imports on src modules not exported by the project. The project only exports Hls by default for JavaScript and all the types exposed by the API for TypeScript.

[jer-0]

I argue that isSupported should be re exported because static methods aren't tree shakable by bundlers.

[robwalch]

I argue that isSupported should be re exported because static methods aren't tree shakable by bundlers.

That would be a breaking change for users that call Hls.isSupported.

We could consider a feature request to remove static methods and provide named exports in v2. That could work for users pulling in the ESM build, but might require changes for folks pulling in the es5 UMD build.

[jer-0]

I argue that isSupported should be re exported because static methods aren't tree shakable by bundlers.

That would be a breaking change for users that call Hls.isSupported.

not necessarily, isSupported can just be exported from src/hls.ts. No need to remove it as a static method.

export { isSupported }

[robwalch]

isSupported can just be exported from src/hls.ts.

That's what we wanted to do in #5685, but can not because Hls is the default export.

[!] Error: Entry module "src/hls.ts" is using named and default exports together. Consumers of your bundle will have to use `Hls.default` to access the default export, which may not be what you want. Use `output.exports: "named"` to disable this warning

[robwalch]

With #5930 we export all enums and classes on the public API. If you'd like static functions on the API (Hls) to be exported independently of the API, please open an PR that adds the named export.