Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to node 18, unpin netlify-cli, and workaround npm ci then being broken #5180

Merged
merged 10 commits into from
Jan 23, 2023
Merged

switch to node 18, unpin netlify-cli, and workaround npm ci then being broken #5180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5ea6664
switch to node 18
tjenkinson Jan 21, 2023
17a71d4
unpin `netlify-cli`
tjenkinson Jan 21, 2023
740692d
use `npm-ci-please` to workaound `npm ci` being broken
tjenkinson Jan 21, 2023
66c92a8
set version using `npm version`
tjenkinson Jan 21, 2023
82dd1c2
be selective about what goes in artifact
tjenkinson Jan 21, 2023
2009084
use newer `npm-ci-please`
tjenkinson Jan 21, 2023
a443b00
fix setting version on netlify
tjenkinson Jan 21, 2023
f428c4f
fix permission on script
tjenkinson Jan 21, 2023
f687673
listen on all interfaces for sauce labs
tjenkinson Jan 22, 2023
09e01d3
Merge branch 'master' into node-18
tjenkinson Jan 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/automerge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ jobs:
with:
repo-token: ${{ secrets.CI_GITHUB_TOKEN }}
allowed-actors: renovate[bot]
package-block-list: netlify-cli
22 changes: 12 additions & 10 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand All @@ -94,7 +94,7 @@ jobs:

- name: set version
run: |
node ./scripts/set-package-version.js
./scripts/set-package-version.sh
env:
CI: true
TAG: ${{ needs.config.outputs.tag }}
Expand All @@ -115,10 +115,12 @@ jobs:
uses: actions/upload-artifact@v3
with:
name: build
# version number is set in package.json so need to include that
path: |
**
!**/[.]*/**
!**/node_modules/
package.json
package-lock.json
api-docs/**
dist/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need demo/** and docs/**? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't do because nothing builds into those folders, so using the versions from the branch in the later stages should be fine


test_unit:
needs: build
Expand Down Expand Up @@ -150,7 +152,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -191,7 +193,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -291,7 +293,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -353,7 +355,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down Expand Up @@ -435,7 +437,7 @@ jobs:

- name: install
run: |
npm ci
npx -y npm-ci-please@^1.1.1
env:
CI: true

Expand Down
2 changes: 1 addition & 1 deletion .node-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
18
Loading