switch to node 18, unpin netlify-cli, and workaround npm ci then being broken
#5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is now LTS
tjenkinson
changed the title
netlify-cli, and workaround npm ci then being broken
|
Hmm the workaround doesn't seem to be reliable |
which will also update the version in the package-lock
to speed things up
tjenkinson
force-pushed
the
node-18
branch
2 times, most recently
from
d84876d
to
ce8b304
Compare
because otherwise with node 18 the server is not reachable through the proxy for some reason
robwalch
reviewed
Jan 23, 2023
| package.json | ||
| package-lock.json | ||
| api-docs/** | ||
| dist/** |
There was a problem hiding this comment.
Do we need demo/** and docs/**? 🤔
There was a problem hiding this comment.
Shouldn't do because nothing builds into those folders, so using the versions from the branch in the later stages should be fine
|
Sorry I just merged it thinking you'd approved and then noticed you hadn't 🤦 |
No worries as long as CI is up. Thanks for addressing this. |
robwalch
pushed a commit
that referenced
this pull request
Jan 26, 2023
…being broken (#5180) * switch to node 18 which is now LTS * unpin `netlify-cli` * use `npm-ci-please` to workaound `npm ci` being broken fixes #5115 * set version using `npm version` which will also update the version in the package-lock * be selective about what goes in artifact to speed things up * use newer `npm-ci-please` * fix setting version on netlify * fix permission on script * listen on all interfaces for sauce labs because otherwise with node 18 the server is not reachable through the proxy for some reason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Switch to node 18, unpin
netlify-cli, and workaroundnpm cithen being broken.netlify/cli#5323 has more info on the
npm ciissue. Hopefully at some point npm will be fixed.Also uses
npm versionto set the version because previously the version was not being updated in the lock file.And only uploads the files that are needed to the artifact instead of everything to make it faster.
And when running with sauce labs configures the server to listen on all interfaces because otherwise with node 18 for some reason it's not reachable through the proxy.
Why is this Pull Request needed?
Node 18 is now LTS, and a newer
netlify-cifixes a security issue.Fixes #5115