docs: update documentation to support new version of dockerfile #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the version of both argocd and ksops to newer versions and changes the paths to reflect what is configured in the new slim docker image introduced in viaduct-ai#180 ArgoCD v2.6.7 is the latest version available on the argoproj docker registry at the time of this commit.
|
|
||
| # Copy the plugin to kustomize plugin path | ||
| COPY --from=ksops-builder /go/src/github.com/viaduct-ai/kustomize-sops/* $KUSTOMIZE_PLUGIN_PATH/viaduct.ai/v1/${PKG_NAME}/ | ||
| COPY --from=ksops-builder /usr/local/bin/ksops $KUSTOMIZE_PLUGIN_PATH/viaduct.ai/v1/${PKG_NAME}/ |
There was a problem hiding this comment.
Previously I just had install -D ksops /custom-tools/kustomize-plugins/viaduct.ai/v1/ksops/ksops;
Should we change the working directory of the container to keep that working?
There was a problem hiding this comment.
As in change the work dir of the KSOPS image to /usr/local/bin/?
There was a problem hiding this comment.
@james-callahan Let me know if this PR addresses: https://github.com/viaduct-ai/kustomize-sops/pull/185/files
devstein
approved these changes
May 18, 2023
|
|
||
| # Copy the plugin to kustomize plugin path | ||
| COPY --from=ksops-builder /go/src/github.com/viaduct-ai/kustomize-sops/* $KUSTOMIZE_PLUGIN_PATH/viaduct.ai/v1/${PKG_NAME}/ | ||
| COPY --from=ksops-builder /usr/local/bin/ksops $KUSTOMIZE_PLUGIN_PATH/viaduct.ai/v1/${PKG_NAME}/ |
There was a problem hiding this comment.
As in change the work dir of the KSOPS image to /usr/local/bin/?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the version of both argocd and ksops to newer
versions and changes the paths to reflect what is configured in the
new slim docker image introduced in #180
ArgoCD v2.6.7 is the latest version available on the argoproj docker
registry at the time of this commit.