fix: reduce size of docker image by leveraging a multi-stage build #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealdwright
force-pushed
the
reduce-docker-image-size
branch
from
8f7598a to
cfc5d8b
Compare
devstein
reviewed
May 17, 2023
The current docker image builds to about 2.7GB on my machine, this can be improved through leveraging multi-stage builds in docker. With this commit, the new image size will be less than 200mb and the necessary binaries are copied to /usr/local/bin Closes viaduct-ai#175
therealdwright
force-pushed
the
reduce-docker-image-size
branch
from
cfc5d8b to
a21e71a
Compare
| @@ -4,7 +4,8 @@ ARG GO_VERSION="1.19" | |||
| #--------Build KSOPS and Kustomize-----------# | |||
| #--------------------------------------------# | |||
|
|
|||
| FROM golang:$GO_VERSION | |||
| # Stage 1: Build KSOPS and Kustomize | |||
| FROM golang:$GO_VERSION AS builder | |||
|
|
|||
| LABEL org.opencontainers.image.source="https://github.com/viaduct-ai/kustomize-sops" | |||
There was a problem hiding this comment.
The LABEL needs to be moved down to the final image
therealdwright
added a commit
to therealdwright/kustomize-sops
that referenced
this pull request
May 17, 2023
Addresses feedback left in viaduct-ai#180
devstein
pushed a commit
that referenced
this pull request
May 17, 2023
Addresses feedback left in #180
|
Hi, this PR has made the Custom ArgoCD Image doc outdated: https://github.com/viaduct-ai/kustomize-sops#custom-argo-cd-w-ksops-dockerfile |
Thanks for flagging @Piroddi - I'll push a PR to fix the docs today. |
therealdwright
added a commit
to therealdwright/kustomize-sops
that referenced
this pull request
May 17, 2023
This commit changes the version of both argocd and ksops to newer versions and changes the paths to reflect what is configured in the new slim docker image introduced in viaduct-ai#180 ArgoCD v2.6.7 is the latest version available on the argoproj docker registry at the time of this commit.
devstein
pushed a commit
that referenced
this pull request
May 18, 2023
This commit changes the version of both argocd and ksops to newer versions and changes the paths to reflect what is configured in the new slim docker image introduced in #180 ArgoCD v2.6.7 is the latest version available on the argoproj docker registry at the time of this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docker image builds to about 2.7GB on my machine, this
can be improved through leveraging multi-stage builds in docker.
With this commit, the new image size will be less than 200mb and
the necessary binaries are copied to /usr/local/bin
Closes #175