Test newer releases of CDK for Secret bug fix (CDK bug # 4151) #22
Assignees
Labels
chore
Incorporating something done by others, like upgrading dependencies, etc.
Milestone
Comments
vgribok
added a commit
that referenced
this issue
Nov 14, 2019
vgribok
added a commit
that referenced
this issue
Nov 14, 2019
vgribok
added a commit
that referenced
this issue
Nov 14, 2019
vgribok
added a commit
that referenced
this issue
Nov 14, 2019
… SDK 3.0 before building & deploy hosting env stack with CDK 1.16.
vgribok
added a commit
that referenced
this issue
Nov 14, 2019
…y a non-empty ECR repo lead to Cfn stack deletion failure, resulting in even more manual cleanup required, compared to just manually deleting the ECR repo after "cdk destroy".
vgribok
added a commit
that referenced
this issue
Nov 14, 2019
|
vgribok
added a commit
that referenced
this issue
Nov 17, 2019
vgribok
added a commit
that referenced
this issue
Nov 17, 2019
[Container] 2019/11/17 00:22:34 Waiting for agent ping
[Container] 2019/11/17 00:22:36 Waiting for DOWNLOAD_SOURCE
[Container] 2019/11/17 00:22:37 Phase is DOWNLOAD_SOURCE
[Container] 2019/11/17 00:22:37 CODEBUILD_SRC_DIR=/codebuild/output/src545232728/src
[Container] 2019/11/17 00:22:37 YAML location is /codebuild/readonly/buildspec.yml
[Container] 2019/11/17 00:22:37 No commands found for phase name: INSTALL
[Container] 2019/11/17 00:22:37 Processing environment variables
[Container] 2019/11/17 00:22:37 Moving to directory /codebuild/output/src545232728/src
[Container] 2019/11/17 00:22:37 Registering with agent
[Container] 2019/11/17 00:22:37 Phases found in YAML: 3
[Container] 2019/11/17 00:22:37 INSTALL: 0 commands
[Container] 2019/11/17 00:22:37 PRE_BUILD: 11 commands
[Container] 2019/11/17 00:22:37 BUILD: 5 commands
[Container] 2019/11/17 00:22:37 Phase complete: DOWNLOAD_SOURCE State: SUCCEEDED
[Container] 2019/11/17 00:22:37 Phase context status code: Message:
[Container] 2019/11/17 00:22:37 Entering phase INSTALL
[Container] 2019/11/17 00:22:37 Running command echo "Installing Node.js version 10 ..."
Installing Node.js version 10 ...
[Container] 2019/11/17 00:22:37 Running command n 10.16.3
installing : node-v10.16.3
mkdir : /usr/local/n/versions/node/10.16.3
fetch : https://nodejs.org/dist/v10.16.3/node-v10.16.3-linux-x64.tar.gz
installed : v10.16.3 (with npm 6.9.0)
[Container] 2019/11/17 00:22:42 Phase complete: INSTALL State: SUCCEEDED
[Container] 2019/11/17 00:22:42 Phase context status code: Message:
[Container] 2019/11/17 00:22:42 Entering phase PRE_BUILD
[Container] 2019/11/17 00:22:42 Running command aws --version
aws-cli/1.16.278 Python/3.6.8 Linux/4.14.146-93.123.amzn1.x86_64 exec-env/AWS_ECS_EC2 botocore/1.13.14
[Container] 2019/11/17 00:22:45 Running command npm install -g aws-cdk${CdkVersion}
/usr/local/bin/cdk -> /usr/local/lib/node_modules/aws-cdk/bin/cdk
> [email protected] postinstall /usr/local/lib/node_modules/aws-cdk/node_modules/core-js
> node postinstall || echo "ignore"
·[96mThank you for using core-js (·[94m https://github.com/zloirock/core-js ·[96m) for polyfilling JavaScript standard library!·[0m
·[96mThe project needs your help! Please consider supporting of core-js on Open Collective or Patreon: ·[0m
·[96m>·[94m https://opencollective.com/core-js ·[0m
·[96m>·[94m https://www.patreon.com/zloirock ·[0m
·[96mAlso, the author of core-js (·[94m https://github.com/zloirock ·[96m) is looking for a good job -)·[0m
+ [email protected]
added 262 packages from 233 contributors in 10.827s
[Container] 2019/11/17 00:22:56 Running command cdk --version
1.16.3 (build 8c7f593)
[Container] 2019/11/17 00:22:57 Running command wget -q https://packages.microsoft.com/config/ubuntu/18.04/packages-microsoft-prod.deb -O packages-microsoft-prod.deb
[Container] 2019/11/17 00:22:57 Running command dpkg -i packages-microsoft-prod.deb
Selecting previously unselected package packages-microsoft-prod.
(Reading database ... 49285 files and directories currently installed.)
Preparing to unpack packages-microsoft-prod.deb ...
Unpacking packages-microsoft-prod (1.0-ubuntu18.04.2) ...
Setting up packages-microsoft-prod (1.0-ubuntu18.04.2) ...
[Container] 2019/11/17 00:23:00 Running command apt-get update
Ign:1 https://dl.bintray.com/sbt/debian InRelease
Get:2 https://dl.bintray.com/sbt/debian Release [815 B]
Hit:3 https://dl.yarnpkg.com/debian stable InRelease
Get:4 https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease [4003 B]
Hit:5 https://download.mono-project.com/repo/ubuntu stable-bionic InRelease
Get:6 http://security.ubuntu.com/ubuntu bionic-security InRelease [88.7 kB]
Hit:7 http://ppa.launchpad.net/git-core/ppa/ubuntu bionic InRelease
Hit:8 http://archive.canonical.com/ubuntu bionic InRelease
Hit:10 http://archive.ubuntu.com/ubuntu bionic InRelease
Get:11 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 Packages [85.3 kB]
Hit:12 http://ppa.launchpad.net/malteworld/ppa/ubuntu bionic InRelease
Get:13 http://archive.ubuntu.com/ubuntu bionic-updates InRelease [88.7 kB]
Get:14 http://security.ubuntu.com/ubuntu bionic-security/main i386 Packages [516 kB]
Get:15 http://archive.ubuntu.com/ubuntu bionic-backports InRelease [74.6 kB]
Get:16 http://security.ubuntu.com/ubuntu bionic-security/multiverse i386 Packages [4510 B]
Get:17 http://security.ubuntu.com/ubuntu bionic-security/main amd64 Packages [735 kB]
Hit:18 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu bionic InRelease
Get:19 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages [1031 kB]
Hit:20 http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu bionic InRelease
Get:21 http://security.ubuntu.com/ubuntu bionic-security/multiverse amd64 Packages [6508 B]
Get:22 http://security.ubuntu.com/ubuntu bionic-security/restricted amd64 Packages [16.8 kB]
Get:23 http://security.ubuntu.com/ubuntu bionic-security/universe i386 Packages [755 kB]
Get:24 http://security.ubuntu.com/ubuntu bionic-security/universe amd64 Packages [786 kB]
Get:25 http://archive.ubuntu.com/ubuntu bionic-updates/universe i386 Packages [1266 kB]
Get:26 http://archive.ubuntu.com/ubuntu bionic-updates/multiverse amd64 Packages [9578 B]
Get:27 http://archive.ubuntu.com/ubuntu bionic-updates/restricted amd64 Packages [29.9 kB]
Get:28 http://archive.ubuntu.com/ubuntu bionic-updates/main i386 Packages [797 kB]
Get:29 http://archive.ubuntu.com/ubuntu bionic-updates/multiverse i386 Packages [7584 B]
Get:30 http://archive.ubuntu.com/ubuntu bionic-updates/universe amd64 Packages [1312 kB]
Get:31 http://archive.ubuntu.com/ubuntu bionic-backports/universe amd64 Packages [4235 B]
Get:32 http://archive.ubuntu.com/ubuntu bionic-backports/universe i386 Packages [4240 B]
Fetched 7623 kB in 9s (862 kB/s)
Reading package lists...
[Container] 2019/11/17 00:23:13 Running command apt-get -y install apt-transport-https
Reading package lists...
Building dependency tree...
Reading state information...
apt-transport-https is already the newest version (1.6.12).
0 upgraded, 0 newly installed, 0 to remove and 28 not upgraded.
[Container] 2019/11/17 00:23:15 Running command apt-get update
Ign:1 https://dl.bintray.com/sbt/debian InRelease
Get:2 https://dl.bintray.com/sbt/debian Release [815 B]
Hit:3 https://dl.yarnpkg.com/debian stable InRelease
Hit:5 https://packages.microsoft.com/ubuntu/18.04/prod bionic InRelease
Hit:6 https://download.mono-project.com/repo/ubuntu stable-bionic InRelease
Hit:7 http://security.ubuntu.com/ubuntu bionic-security InRelease
Hit:8 http://archive.ubuntu.com/ubuntu bionic InRelease
Hit:9 http://ppa.launchpad.net/git-core/ppa/ubuntu bionic InRelease
Hit:10 http://archive.canonical.com/ubuntu bionic InRelease
Hit:11 http://ppa.launchpad.net/malteworld/ppa/ubuntu bionic InRelease
Hit:12 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:13 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
Hit:14 http://ppa.launchpad.net/openjdk-r/ppa/ubuntu bionic InRelease
Hit:15 http://ppa.launchpad.net/ubuntu-toolchain-r/test/ubuntu bionic InRelease
Fetched 815 B in 1s (631 B/s)
Reading package lists...
[Container] 2019/11/17 00:23:17 Running command apt-get -y install dotnet-sdk-3.0
Reading package lists...
Building dependency tree...
Reading state information...
The following additional packages will be installed:
aspnetcore-runtime-3.0 aspnetcore-targeting-pack-3.0 dotnet-apphost-pack-3.0
dotnet-host dotnet-hostfxr-3.0 dotnet-runtime-3.0 dotnet-runtime-deps-3.0
dotnet-targeting-pack-3.0 netstandard-targeting-pack-2.1
The following NEW packages will be installed:
aspnetcore-runtime-3.0 aspnetcore-targeting-pack-3.0 dotnet-apphost-pack-3.0
dotnet-host dotnet-hostfxr-3.0 dotnet-runtime-3.0 dotnet-runtime-deps-3.0
dotnet-sdk-3.0 dotnet-targeting-pack-3.0 netstandard-targeting-pack-2.1
0 upgraded, 10 newly installed, 0 to remove and 28 not upgraded.
Need to get 74.8 MB of archives.
After this operation, 324 MB of additional disk space will be used.
Get:1 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-host amd64 3.0.0-1 [32.1 kB]
Get:2 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-hostfxr-3.0 amd64 3.0.0-1 [120 kB]
Get:3 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-runtime-deps-3.0 amd64 3.0.0-1 [2666 B]
Get:4 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-runtime-3.0 amd64 3.0.0-1 [21.6 MB]
Get:5 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 aspnetcore-runtime-3.0 amd64 3.0.0-1 [5719 kB]
Get:6 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-targeting-pack-3.0 amd64 3.0.0-1 [1964 kB]
Get:7 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 aspnetcore-targeting-pack-3.0 amd64 3.0.0-1 [837 kB]
Get:8 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-apphost-pack-3.0 amd64 3.0.0-1 [40.7 kB]
Get:9 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 netstandard-targeting-pack-2.1 amd64 2.1.0-1 [1476 kB]
Get:10 https://packages.microsoft.com/ubuntu/18.04/prod bionic/main amd64 dotnet-sdk-3.0 amd64 3.0.100-1 [43.1 MB]
debconf: delaying package configuration, since apt-utils is not installed
Fetched 74.8 MB in 1s (54.6 MB/s)
Selecting previously unselected package dotnet-host.
(Reading database ...
(Reading database ... 5%
(Reading database ... 10%
(Reading database ... 15%
(Reading database ... 20%
(Reading database ... 25%
(Reading database ... 30%
(Reading database ... 35%
(Reading database ... 40%
(Reading database ... 45%
(Reading database ... 50%
(Reading database ... 55%
(Reading database ... 60%
(Reading database ... 65%
(Reading database ... 70%
(Reading database ... 75%
(Reading database ... 80%
(Reading database ... 85%
(Reading database ... 90%
(Reading database ... 95%
(Reading database ... 100%
(Reading database ... 49293 files and directories currently installed.)
Preparing to unpack .../0-dotnet-host_3.0.0-1_amd64.deb ...
Unpacking dotnet-host (3.0.0-1) ...
Selecting previously unselected package dotnet-hostfxr-3.0.
Preparing to unpack .../1-dotnet-hostfxr-3.0_3.0.0-1_amd64.deb ...
Unpacking dotnet-hostfxr-3.0 (3.0.0-1) ...
Selecting previously unselected package dotnet-runtime-deps-3.0.
Preparing to unpack .../2-dotnet-runtime-deps-3.0_3.0.0-1_amd64.deb ...
Unpacking dotnet-runtime-deps-3.0 (3.0.0-1) ...
Selecting previously unselected package dotnet-runtime-3.0.
Preparing to unpack .../3-dotnet-runtime-3.0_3.0.0-1_amd64.deb ...
Unpacking dotnet-runtime-3.0 (3.0.0-1) ...
Selecting previously unselected package aspnetcore-runtime-3.0.
Preparing to unpack .../4-aspnetcore-runtime-3.0_3.0.0-1_amd64.deb ...
Unpacking aspnetcore-runtime-3.0 (3.0.0-1) ...
Selecting previously unselected package dotnet-targeting-pack-3.0.
Preparing to unpack .../5-dotnet-targeting-pack-3.0_3.0.0-1_amd64.deb ...
Unpacking dotnet-targeting-pack-3.0 (3.0.0-1) ...
Selecting previously unselected package aspnetcore-targeting-pack-3.0.
Preparing to unpack .../6-aspnetcore-targeting-pack-3.0_3.0.0-1_amd64.deb ...
Unpacking aspnetcore-targeting-pack-3.0 (3.0.0-1) ...
Selecting previously unselected package dotnet-apphost-pack-3.0.
Preparing to unpack .../7-dotnet-apphost-pack-3.0_3.0.0-1_amd64.deb ...
Unpacking dotnet-apphost-pack-3.0 (3.0.0-1) ...
Selecting previously unselected package netstandard-targeting-pack-2.1.
Preparing to unpack .../8-netstandard-targeting-pack-2.1_2.1.0-1_amd64.deb ...
Unpacking netstandard-targeting-pack-2.1 (2.1.0-1) ...
Selecting previously unselected package dotnet-sdk-3.0.
Preparing to unpack .../9-dotnet-sdk-3.0_3.0.100-1_amd64.deb ...
Unpacking dotnet-sdk-3.0 (3.0.100-1) ...
Setting up dotnet-host (3.0.0-1) ...
Setting up dotnet-hostfxr-3.0 (3.0.0-1) ...
Setting up netstandard-targeting-pack-2.1 (2.1.0-1) ...
Setting up dotnet-apphost-pack-3.0 (3.0.0-1) ...
Setting up dotnet-runtime-deps-3.0 (3.0.0-1) ...
Setting up dotnet-targeting-pack-3.0 (3.0.0-1) ...
Setting up dotnet-runtime-3.0 (3.0.0-1) ...
Setting up aspnetcore-targeting-pack-3.0 (3.0.0-1) ...
Setting up aspnetcore-runtime-3.0 (3.0.0-1) ...
Setting up dotnet-sdk-3.0 (3.0.100-1) ...
This software may collect information about you and your use of the software, and send that to Microsoft.
Please visit http://aka.ms/dotnet-cli-eula for more information.
Welcome to .NET Core!
---------------------
Learn more about .NET Core: https://aka.ms/dotnet-docs
Use 'dotnet --help' to see available commands or visit: https://aka.ms/dotnet-cli-docs
Telemetry
---------
The .NET Core tools collect usage data in order to help us improve your experience. The data is anonymous and doesn't include command-line arguments. The data is collected by Microsoft and shared with the community. You can opt-out of telemetry by setting the DOTNET_CLI_TELEMETRY_OPTOUT environment variable to '1' or 'true' using your favorite shell.
Read more about .NET Core CLI Tools telemetry: https://aka.ms/dotnet-cli-telemetry
Configuring...
--------------
A command is running to populate your local package cache to improve restore speed and enable offline access. This command takes up to one minute to complete and only runs once.
[Container] 2019/11/17 00:23:31 Running command dotnet --info
.NET Core SDK (reflecting any global.json):
Version: 3.0.100
Commit: 04339c3a26
Runtime Environment:
OS Name: ubuntu
OS Version: 18.04
OS Platform: Linux
RID: ubuntu.18.04-x64
Base Path: /usr/share/dotnet/sdk/3.0.100/
Host (useful for support):
Version: 3.0.0
Commit: 95a0a61858
.NET Core SDKs installed:
3.0.100 [/usr/share/dotnet/sdk]
.NET Core runtimes installed:
Microsoft.AspNetCore.App 3.0.0 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.0.0 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET Core runtimes or SDKs:
https://aka.ms/dotnet-download
[Container] 2019/11/17 00:23:31 Running command dotnet --version
3.0.100
[Container] 2019/11/17 00:23:31 Phase complete: PRE_BUILD State: SUCCEEDED
[Container] 2019/11/17 00:23:31 Phase context status code: Message:
[Container] 2019/11/17 00:23:31 Entering phase BUILD
[Container] 2019/11/17 00:23:31 Running command echo Building CDK CI/CD project
Building CDK CI/CD project
[Container] 2019/11/17 00:23:31 Running command cd ./infra-as-code/ProdEnvInfraAsCode/src
[Container] 2019/11/17 00:23:31 Running command dotnet build ProdEnvInfraAsCode.csproj -c ${BuildConfig}${DbEngine}
Microsoft (R) Build Engine version 16.3.0+0f4c62fea for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.
Restore completed in 2.48 sec for /codebuild/output/src545232728/src/infra-as-code/ProdEnvInfraAsCode/src/ProdEnvInfraAsCode.csproj.
Restore completed in 2.48 sec for /codebuild/output/src545232728/src/infra-as-code/CdkLib/CdkLib.csproj.
CdkLib -> /codebuild/output/src545232728/src/infra-as-code/CdkLib/bin/local/DebugPostgres/netcoreapp3.0/CdkLib.dll
ProdEnvInfraAsCode -> /codebuild/output/src545232728/src/infra-as-code/ProdEnvInfraAsCode/src/bin/local/Debug/netcoreapp3.0/ProdEnvInfraAsCode.dll
Build succeeded.
0 Warning(s)
0 Error(s)
Time Elapsed 00:00:04.69
[Container] 2019/11/17 00:23:36 Running command cdk diff || true
Synthesized to "cdk.out".
Stack UnicornSuperstoreStack
There were no differences
[Container] 2019/11/17 00:23:40 Running command cdk deploy --require-approval never
Synthesized to "cdk.out".
UnicornSuperstoreStack: deploying...
UnicornSuperstoreStack: creating CloudFormation changeset...
✅ UnicornSuperstoreStack (no changes)
Outputs:
UnicornSuperstoreStack.UnicornSuperstoreFargateServiceLoadBalancerDNS9647361B = unicorn-store-925331112.us-west-2.elb.amazonaws.com
UnicornSuperstoreStack.UnicornSuperstoreFargateServiceServiceURL66728ACA = http://unicorn-store-925331112.us-west-2.elb.amazonaws.com
Stack ARN:
arn:aws:cloudformation:us-west-2:444039259723:stack/UnicornSuperstoreStack/7b81fc70-08c4-11ea-851b-0696a78c5fe8
[Container] 2019/11/17 00:23:44 Phase complete: BUILD State: SUCCEEDED
[Container] 2019/11/17 00:23:44 Phase context status code: Message:
[Container] 2019/11/17 00:23:44 Entering phase POST_BUILD
[Container] 2019/11/17 00:23:44 Phase complete: POST_BUILD State: SUCCEEDED
[Container] 2019/11/17 00:23:44 Phase context status code: Message:
vgribok
added
the
chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Story
As a Unicorn Store CDK lab participant
I want the code working around CDK bug 4151 to be removed to avoid confusion and distraction
So that I could see only best practice code and not irrelevant code
Details
.NET CDK appears to have a bug making Secret Manager secret definition logic unnecessarily complex. Please check after each CDK release (releases are quite frequent) to see whether CDK bug 4151 and remove the
WrapSecretBug()method and refactor broken code.Acceptance Criteria
Demo
WrapSecretBug()method removed while CDK projects working properly.The text was updated successfully, but these errors were encountered: