Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share memory for vertex and edge value (#1565) #5000

Merged
merged 2 commits into from
Dec 7, 2022

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 6, 2022

  • shallow copy vertex & edgee

  • add delete

  • fix error

  • delete error code

  • optimize getVertex

  • fix memory leak

  • delete useless code

  • address comment

  • fix multiple threads double free pointer problem

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

The type of vertex and edge in value is replaced from raw pointer to unique_ptr in other PR

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready for review ready-for-testing PR: ready for the CI test labels Dec 6, 2022
@yixinglu yixinglu changed the title shallow copy vertex & edgee (#1565) Share memory for vertex and edge value (#1565) Dec 6, 2022
yixinglu
yixinglu previously approved these changes Dec 7, 2022
xtcyclist
xtcyclist previously approved these changes Dec 7, 2022
* shallow copy vertex & edgee

* add delete

* fix error

* delete error code

* optimize getVertex

* fix memory leak

* delete useless code

* address comment

* fix multiple threads double free  pointer problem
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Dec 7, 2022
@Sophie-Xie Sophie-Xie merged commit 3762db7 into vesoft-inc:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants