Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]Added docs on build from source #1565

Merged
merged 7 commits into from
Jan 6, 2020
Merged

[doc]Added docs on build from source #1565

merged 7 commits into from
Jan 6, 2020

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Dec 31, 2019

This PR documents the new building scheme offered in #1332

The cn version comes next.

whitewum
whitewum previously approved these changes Dec 31, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

- If no errors are shown
#### CMAKE_BUILD_TYPE
There are a few building types supported:
* `Debug`, to build with debuginfo but without optimization, which is by default

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug, to build with debuginfo but without optimization by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by default is to qualify Debug. I think it is more clear.

@nebula-community-bot
Copy link
Member

Unit testing passed.

amber-moe
amber-moe previously approved these changes Jan 3, 2020
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@amber-moe amber-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for taking care of this.

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit bf06ddf into vesoft-inc:master Jan 6, 2020
@dutor dutor deleted the add-docs-on-build branch January 6, 2020 02:11
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* Added docs on build from source

* Update for Arch and Gentoo

* Address @Amber1990Zhang's and @wilsonyou's comments

* Address @wilsonyou's comments
nevermore3 added a commit to nevermore3/nebula that referenced this pull request Dec 6, 2022
* shallow copy vertex & edgee

* add delete

* fix error

* delete error code

* optimize getVertex

* fix memory leak

* delete useless code

* address comment

* fix multiple threads double free  pointer problem
xtcyclist pushed a commit to nevermore3/nebula that referenced this pull request Dec 7, 2022
* shallow copy vertex & edgee

* add delete

* fix error

* delete error code

* optimize getVertex

* fix memory leak

* delete useless code

* address comment

* fix multiple threads double free  pointer problem
xtcyclist pushed a commit to nevermore3/nebula that referenced this pull request Dec 7, 2022
* shallow copy vertex & edgee

* add delete

* fix error

* delete error code

* optimize getVertex

* fix memory leak

* delete useless code

* address comment

* fix multiple threads double free  pointer problem
Sophie-Xie added a commit that referenced this pull request Dec 7, 2022
* shallow copy vertex & edgee

* add delete

* fix error

* delete error code

* optimize getVertex

* fix memory leak

* delete useless code

* address comment

* fix multiple threads double free  pointer problem

Co-authored-by: Sophie <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
* shallow copy vertex & edgee

* add delete

* fix error

* delete error code

* optimize getVertex

* fix memory leak

* delete useless code

* address comment

* fix multiple threads double free  pointer problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants