Fix argument #4950
Merged
Fix argument #4950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
force-pushed
the
fix/argument-input-var
branch
from
6c9d6f8
to
2b04f2a
Compare
czpmango
added
ready-for-testing
Shylock-Hg
reviewed
Nov 29, 2022
| @@ -147,10 +147,10 @@ class PassThroughNode final : public SingleInputNode { | |||
| }; | |||
|
|
|||
| // This operator is used for getting a named alias from another executed operator. | |||
| class Argument final : public SingleInputNode { | |||
| class Argument final : public PlanNode { | |||
There was a problem hiding this comment.
Treat Argument as a leaf node and delete the useless StartNode.
There was a problem hiding this comment.
Emm. A little wired, node with one input should inherit it.
czpmango
force-pushed
the
fix/argument-input-var
branch
2 times, most recently
from
e8079f0
to
52a01be
Compare
fix shortest path fix argument input var fix fix tck add tck fix tck fmt
czpmango
force-pushed
the
fix/argument-input-var
branch
from
f868ab3
to
718f153
Compare
jievince
approved these changes
Nov 29, 2022
Aiee
approved these changes
Nov 29, 2022
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4936
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: