Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix explain of argument #4946

Closed
wants to merge 1 commit into from

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Nov 29, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #4945

Description:

Because Argument inherited from SingleInputNode, so it doesn't need to override the explain interface
Related pr: https://github.com/vesoft-inc/nebula/pull/4939/files#.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince added the ready-for-testing PR: ready for the CI test label Nov 29, 2022
@Shylock-Hg
Copy link
Contributor

Argument has a member alias_

@jievince
Copy link
Contributor Author

Argument has a member alias_

It's a little redundant... Because alias is always the same as the column name of the argument output

@jievince
Copy link
Contributor Author

Close this because #4950 has fixed it.

@jievince jievince closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile shows arguments plan node has two same input variable
2 participants