Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete vertex or edge, the storage crashed.(issue: #4397) #4406

Merged

Conversation

Milittle
Copy link
Contributor

What type of PR is this?

  • bug

What problem(s) does this PR solve?

Issue(s) number: 4397

Description:

  • When our space has tag index or edge index.
  • When delete vertex or edge, we specify one vid more than our defined
    in space.
  • The sotrage will be crashed.

How do you solve it?

Solution:

  1. Add vid valid verfication.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • N/A

Affects:

  • N/A

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed storaged crashed, when we delete vertex and edge specify vid more than our defined before in space.

* When our space has tag index or edge index.
* When delete vertex or edge, we specify one vid more than our defined
  in space.
* The sotrage will be crashed.

Solution:
1. Add vid valid verfication.
@CLAassistant
Copy link

CLAassistant commented Jul 12, 2022

CLA assistant check
All committers have signed the CLA.

@Milittle Milittle changed the title Fix delete vertex or edge, the storage crashed.(#4397) Fix delete vertex or edge, the storage crashed.(issue: #4397) Jul 12, 2022
@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test cherry-pick-v3.2 PR: need cherry-pick to this version labels Jul 12, 2022
Copy link
Contributor

@SuperYoko SuperYoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's now enough to stop crash due to this check.

  1. This check means that somebody must guarantee it, and the earlier the better, maybe later there's some fix.
  2. TCK needed, Maybe later this week I'll add it.

@critical27 critical27 merged commit 7079ef5 into vesoft-inc:master Jul 13, 2022
Sophie-Xie added a commit that referenced this pull request Jul 13, 2022
* When our space has tag index or edge index.
* When delete vertex or edge, we specify one vid more than our defined
  in space.
* The sotrage will be crashed.

Solution:
1. Add vid valid verfication.

Co-authored-by: Sophie <[email protected]>
@wey-gu
Copy link
Contributor

wey-gu commented Jul 13, 2022

LGTM. It's now enough to stop crash due to this check.

  1. This check means that somebody must guarantee it, and the earlier the better, maybe later there's some fix.
  2. TCK needed, Maybe later this week I'll add it.

Thanks @SuperYoko :)

critical27 pushed a commit that referenced this pull request Jul 13, 2022
* Fix web service crash(issue:#4398) (#4405)

* when we use flags put interface, but we does not specify the body.
* The service will be crashed.
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags

* Fix delete vertex or edge, the storage crashed.(#4397) (#4406)

* When our space has tag index or edge index.
* When delete vertex or edge, we specify one vid more than our defined
  in space.
* The sotrage will be crashed.

Solution:
1. Add vid valid verfication.

Co-authored-by: Sophie <[email protected]>

* Release with separate debug info in ELF format (#4400)

Co-authored-by: Milittle <[email protected]>
Co-authored-by: dutor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.2 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage Crash when deleting vertex does not exist and vid length more than we define in space.
6 participants