-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delete vertex or edge, the storage crashed.(issue: #4397) #4406
Merged
critical27
merged 2 commits into
vesoft-inc:master
from
Milittle:fix_delete_vertex_and_edge_crash
Jul 13, 2022
Merged
Fix delete vertex or edge, the storage crashed.(issue: #4397) #4406
critical27
merged 2 commits into
vesoft-inc:master
from
Milittle:fix_delete_vertex_and_edge_crash
Jul 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When our space has tag index or edge index. * When delete vertex or edge, we specify one vid more than our defined in space. * The sotrage will be crashed. Solution: 1. Add vid valid verfication.
Milittle
changed the title
Fix delete vertex or edge, the storage crashed.(#4397)
Fix delete vertex or edge, the storage crashed.(issue: #4397)
Jul 12, 2022
Sophie-Xie
added
ready-for-testing
PR: ready for the CI test
cherry-pick-v3.2
PR: need cherry-pick to this version
labels
Jul 12, 2022
SuperYoko
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's now enough to stop crash due to this check.
- This check means that somebody must guarantee it, and the earlier the better, maybe later there's some fix.
- TCK needed, Maybe later this week I'll add it.
critical27
approved these changes
Jul 13, 2022
Sophie-Xie
added a commit
that referenced
this pull request
Jul 13, 2022
* When our space has tag index or edge index. * When delete vertex or edge, we specify one vid more than our defined in space. * The sotrage will be crashed. Solution: 1. Add vid valid verfication. Co-authored-by: Sophie <[email protected]>
Thanks @SuperYoko :) |
critical27
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Fix web service crash(issue:#4398) (#4405) * when we use flags put interface, but we does not specify the body. * The service will be crashed. For example: curl -X PUT xxx.xxx.xxx.xxxx:19559/flags * Fix delete vertex or edge, the storage crashed.(#4397) (#4406) * When our space has tag index or edge index. * When delete vertex or edge, we specify one vid more than our defined in space. * The sotrage will be crashed. Solution: 1. Add vid valid verfication. Co-authored-by: Sophie <[email protected]> * Release with separate debug info in ELF format (#4400) Co-authored-by: Milittle <[email protected]> Co-authored-by: dutor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: 4397
Description:
in space.
How do you solve it?
Solution:
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: