Fix web service crash(issue:#4398) #4405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
* when we use flags put interface, but we does not specify the body. * The service will be crashed. For example: curl -X PUT xxx.xxx.xxx.xxxx:19559/flags
Milittle
force-pushed
the
fix_http_put_crash
branch
from
ea18e10
to
e94f6b5
Compare
Sophie-Xie
added
ready-for-testing
critical27
approved these changes
Jul 13, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Jul 13, 2022
critical27
pushed a commit
that referenced
this pull request
Jul 13, 2022
* Fix web service crash(issue:#4398) (#4405) * when we use flags put interface, but we does not specify the body. * The service will be crashed. For example: curl -X PUT xxx.xxx.xxx.xxxx:19559/flags * Fix delete vertex or edge, the storage crashed.(#4397) (#4406) * When our space has tag index or edge index. * When delete vertex or edge, we specify one vid more than our defined in space. * The sotrage will be crashed. Solution: 1. Add vid valid verfication. Co-authored-by: Sophie <[email protected]> * Release with separate debug info in ELF format (#4400) Co-authored-by: Milittle <[email protected]> Co-authored-by: dutor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number: #4398
Description:
For example:
curl -X PUT xxx.xxx.xxx.xxxx:19559/flags
How do you solve it?
Checking for body_, if we got nullptr, Ignore this request.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: