Add kvstore rate limiter #2557
Merged
Add kvstore rate limiter #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
cangfengzhs,
liuyu85cn,
bright-starry-sky and
panda-sheep
|
|
critical27
force-pushed
the
rate
branch
2 times, most recently
from
bb176da to
0ed0962
Compare
| } | ||
|
|
||
| void consume(GraphSpaceID spaceId, PartitionID partId, size_t toConsume) { | ||
| DCHECK(buckets_.find({spaceId, partId}) != buckets_.end()); |
There was a problem hiding this comment.
Is it redundant?
There was a problem hiding this comment.
Yeah, just to prevent misuse.
There was a problem hiding this comment.
Doesn't it need to be locked here?
There was a problem hiding this comment.
There won't be concurrent add/remove/consume of a {spaceId, partId}. Caller must make sure part has been added, and won't remove during consume. I'll add some comments.
|
Good job , LGTM . |
bright-starry-sky
previously approved these changes
Aug 26, 2021
critical27
dismissed stale reviews from bright-starry-sky and panda-sheep
via
2f9dd3e
bright-starry-sky
approved these changes
Aug 26, 2021
panda-sheep
approved these changes
Aug 26, 2021
critical27
added a commit
to critical27/nebula
that referenced
this pull request
Aug 31, 2021
bright-starry-sky
pushed a commit
that referenced
this pull request
Aug 31, 2021
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* get meta version in hb * cherry-pick vesoft-inc#549 vesoft-inc#550 vesoft-inc#551 * damn timeout * fix rebuild index bug introduced in vesoft-inc#2557 Co-authored-by: Doodle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a simple rate limiter, there are mainly two major cases: