Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS]Delete an Vertex #551

Closed
2 tasks done
zlcook opened this issue Jun 28, 2019 · 3 comments
Closed
2 tasks done

[DISCUSS]Delete an Vertex #551

zlcook opened this issue Jun 28, 2019 · 3 comments
Assignees
Milestone

Comments

@zlcook
Copy link
Contributor

zlcook commented Jun 28, 2019

  • Delete a vertex:
DELETE VERTEX vid

graph layer need send three requests to delete a vertex:

  1. First request, get all edgeKeys(out-edges and in-edges) of the vertex needed te be deleted.
  2. Second request, delete the all edges of the vertex accroding to the edgeKeys.
  3. Finally, delete the vertex
  • parser
  • executor and tests in graphd
@whitewum
Copy link
Contributor

whitewum commented Jun 28, 2019

  1. first delete the surrounding edges then delete the vertex (in case of hangling edges)
  2. when deleting a huge vertex ( a lot of in and out edges), the deleting process will be very very long (and may fail).
  3. I'd prefer not to save the process in meta-server, and not to provide operation transactions, just let graph-client to check the result (e.g., double vertex delete).
  4. maybe hangling edge is also an available option, let user make the choice when deleting.

@sherman-the-tank sherman-the-tank changed the title 【DISCUSS】Delete an Vertex [DISCUSS]Delete an Vertex Jun 30, 2019
@sherman-the-tank
Copy link
Member

Please DO NOT use Chinese punctuation

@zlcook
Copy link
Contributor Author

zlcook commented Sep 6, 2019

Done

@zlcook zlcook closed this as completed Sep 6, 2019
critical27 added a commit to critical27/nebula that referenced this issue Aug 26, 2021
critical27 added a commit to critical27/nebula that referenced this issue Aug 29, 2021
bright-starry-sky pushed a commit that referenced this issue Aug 31, 2021
* get meta version in hb

* cherry-pick #549 #550 #551

* damn timeout

* fix rebuild index bug introduced in #2557
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
* get meta version in hb

* cherry-pick vesoft-inc#549 vesoft-inc#550 vesoft-inc#551

* damn timeout

* fix rebuild index bug introduced in vesoft-inc#2557

Co-authored-by: Doodle <[email protected]>
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
…t-inc#551)

* improve sync listener code

* add comments

* add comments

* adjust log level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants