Make MathKeyboard IDisposable #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happypig375
reviewed
Oct 24, 2020
|
My Visual Studio does not do this. I am confused as to why does this happen. |
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 87.33% 87.29% -0.04%
==========================================
Files 156 156
Lines 11312 11314 +2
==========================================
- Hits 9879 9877 -2
- Misses 1433 1437 +4
Continue to review full report at Codecov.
|
FoggyFinder
approved these changes
Oct 24, 2020
charlesroddie
added a commit
that referenced
this pull request
Oct 27, 2020
* Add setting LaTeXSettings.PlaceholderBlinks + unit tests * Fix PlaceholderBlinks setting + add unit test CaretStillBlinks * Non-blinking placeholder test "CaretStillBlinks" should also verify that the RestingNucleus is shown for all placeholders if the caret blinks * Refactor: if PlaceholderBlinks is false and ShownThroughPlaceholder true then don't change the CaretState instead of ignoring the changed state later on * Remove MathKeyboardCaretState.ShownThroughPlaceholder and avoid invoking RedrawRequested when state has not changed * Remove nuget.config * add xml * Set PlaceholderBlinks default to false * Don't show cursor if at placeholder * ternary conditional operator * fix ProcessCaretState * Refactor away ProcessCaretState() + fix indentation Also: - Set PlaceholderBlinks back to true because I don't like to do a commit that has failing unit tests. A commit that changes a default, should also change the tests. I will have a look at the changes needed. * change LaTeXSettings.PlaceholderBlinks again and remove tests checking for default blinking behaviour. Remove nuget.Config * Restore parts of some tests + mark CaretIsOverriddenByPlaceholder as "fix or delete" * Replace CaretState enum property by boolean properties "InsertionPositionHighlighted" and "ShouldDrawCaret" General notes: Having a CaretState that says "MathKeyboardCaretState.Shown" while actually no caret is shown because a placeholder is shown is wrong. Having a CaretState "MathKeyboardCaretState.Hidden" and "MathKeyboardCaretState.TemporarilyHidden" is not needed: you can use StopBlinking() just after setting the CaretState you want to keep until the next key press. These two observations resulted in the boolean properties "InsertionPositionHighlighted" (that makes sense for both the caret AND the placeholder appearance) and "ShouldDrawCaret". Because Drawing the caret is done in CSharpMath.Rendering.FrontEnd, the unit tests of CSharpMath.Editor can only test "ShouldDraw" and unit tests that do that can cover the same as before (when it was tested via a MathKeyboardCaretState enum). Notes about moved unit tests: - CaretIsOverriddenByPlaceholder has been replaced by PlaceholderDoesNotBlinkAndNoCaretVisible. - CaretMovesWithPlaceholder has been replaced by NonBlinkingActivePlaceholderMoves. * Make mergable without conflict (after #179 for IDisposable MathKeyboard) * Move method before first using * Fix inconsistent code style * Reverse assertion order * Reverse assertion order - part 2 Co-authored-by: Charles Roddie <[email protected]> Co-authored-by: FoggyFinder <[email protected]>
Happypig375
added
Resolution/Implemented
|
@Happypig375 could you queue a nuget release with this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #178