Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The IDisposable blinkTimer in MathKeyboard is not handled #178

Closed
charlesroddie opened this issue Oct 24, 2020 · 0 comments · Fixed by #179
Closed

The IDisposable blinkTimer in MathKeyboard is not handled #178

charlesroddie opened this issue Oct 24, 2020 · 0 comments · Fixed by #179
Labels
Resolution/Implemented The described enhancement or housekeeping work has been implemented. Type/Housekeeping This includes internal only changes.

Comments

@charlesroddie
Copy link
Collaborator

charlesroddie commented Oct 24, 2020 •
edited
Loading

In MathKeyboard, blinkTimer:Timers.Timer is IDisposable.

This IDisposability should propogate and make the MathKeyboard IDisposable.

Currently this is not handled, and the timer can keep running and keep alive everything it references, leading to memory leaks.
@charlesroddie charlesroddie added Type/Bug Status/0. New This issue is new and is awaiting confirmation from the maintainers. labels Oct 24, 2020
@charlesroddie charlesroddie mentioned this issue Oct 24, 2020
Merged
@Happypig375 Happypig375 added Resolution/Implemented The described enhancement or housekeeping work has been implemented. Type/Housekeeping This includes internal only changes. and removed Status/0. New This issue is new and is awaiting confirmation from the maintainers. Type/Bug labels Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution/Implemented The described enhancement or housekeeping work has been implemented. Type/Housekeeping This includes internal only changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make MathKeyboard IDisposable verybadcat/CSharpMath
2 participants
@charlesroddie @Happypig375