JsSIP.UA disconnected event enhancements

[pontello]

When disconnected event is fired, jssip try unlimited times to recover the transport and there is no way to tell him to stop!

Suggestions:

• Add a new UA configuration parameter to enable/disable the transport recover
• If disconnected event is fired, JsSIP.UA.stop() should also stop the transport recover

What do we have right now is an infinite attempt to recover the transport, even after we call JsSIP.UA.stop() method!

[jmillan]

UA.stop() should stop re-connection attempts. If it does not do it, then it is a bug.

[saghul]

When would you like not to recover from a transport error? I agree that UA.stop should stop the recovery process.

[pontello]

I have one app that connect, make call and disconnect... If I am not able to connect to the server I just inform the user that we have a network error and the call is cancelled.... The process will be repeated only if user try to make a call again...

So, for this use case, I don't what to try to connect again because the connection is not important anymore after some seconds...

[saghul]

Can't you stop the UA after the call is finished?

[pontello]

Yes, sure, but JsSIP.UA.stop() don't stop the transport recover process... My call was not even started on this case...

[jmillan]

Yep, that is the issue. It is being solved.

[saghul]

Of, course, that is, assuming UA.stop actually works :-) Looks like @jmillan is on it 👍

[pontello]

Thank you guys!

[jmillan]

Thank you for reporting @nilsonfreitas

[pontello]

@jmillan

Your fix is not working... Please take a look into UA.prototype.recoverTransport method..

  window.setTimeout(
    function(){
      ua.transportRecoverAttempts = count + 1;
      new JsSIP.Transport(ua, server);
    }, nextRetry * 1000);

This timeout has to be cleared as well... Following code will still send unlimited attempts to reconnect:

uac.once('disconnected', function(e){ 
    uac.stop();
});

[jmillan]

You are absolutely right @nilsonfreitas,

Such timer was not being cleaned. Its done now. Please, give it a try.