Fixup and document cache attachment #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
cache-plugin-attachment
branch
from
0ca0374
to
2af3298
Compare
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 76.23% 76.16% -0.07%
==========================================
Files 10 10
Lines 1111 1112 +1
==========================================
Hits 847 847
- Misses 264 265 +1
Continue to review full report at Codecov.
|
guybedford
added a commit
that referenced
this pull request
Jul 2, 2019
This reverts commit d654e70.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This documents the APIs we've been using for cache persistence and symlink and permission handling.
In addition, it fixes up a cache bug with the public path emission, where we really need to ensure we have a plugin hook to maintain this injection in the fully cached case (as was happening with the bugs on vercel/ncc#442).
This isn't a great API I know, I'm hoping we can improve it. @sokra may have some ideas going forward especially since loaders needing plugin hooks to manage their cache tables seems like a generic problem.