Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Webpack public path #60

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Revert Webpack public path #60

merged 2 commits into from
Jul 2, 2019

Conversation

guybedford
Copy link
Contributor

This reverts the public path change features due to Next.js relying on this behaviour.

Instead, these commits will be moved to a new major release.

@guybedford
Copy link
Contributor Author

//cc @Timer

@codecov-io
Copy link

Codecov Report

Merging #60 into master will increase coverage by 0.03%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   76.16%   76.19%   +0.03%     
==========================================
  Files          10       10              
  Lines        1112     1105       -7     
==========================================
- Hits          847      842       -5     
+ Misses        265      263       -2
Impacted Files Coverage Δ
src/asset-relocator.js 83.81% <85%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45940a...0647ab9. Read the comment docs.

@guybedford guybedford merged commit ccbb342 into master Jul 2, 2019
@guybedford guybedford deleted the revert-public-path branch July 2, 2019 17:41
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants