Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should only update cache when actually start new request #1986

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: should only update cache when actually start new request #1986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1af88df
fix: should only update cache when actually start new request
promer94 May 20, 2022
1e32f6b
chore: ci
promer94 May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/use-swr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,10 +276,10 @@ export const useSWRHandler = <Data = any, Error = any>(
if (isUndefined(getCache().data)) {
initialState.isLoading = true
}
setCache(initialState)

try {
if (shouldStartNewRequest) {
// TODO: should add a test case for this https://github.com/vercel/swr/issues/1974
setCache(initialState)
// If no cache being rendered currently (it shows a blank page),
// we trigger the loading slow event.
if (config.loadingTimeout && isUndefined(getCache().data)) {
Expand Down