Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should only update cache when actually start new request #1986

Merged
merged 2 commits into from
May 25, 2022
Merged

fix: should only update cache when actually start new request #1986

merged 2 commits into from
May 25, 2022

Conversation

promer94
Copy link
Collaborator

@promer94 promer94 commented May 20, 2022 •
edited
Loading

@promer94 promer94 requested review from shuding and huozhi as code owners May 20, 2022 10:28
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 20, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e32f6b:

Sandbox Source
SWR-Basic Configuration
SWR-States Configuration
SWR-Infinite Configuration
SWR-SSR Configuration
loading PR

shuding
shuding reviewed May 20, 2022
View reviewed changes
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! We will need a test for this

huozhi
huozhi reviewed May 24, 2022
View reviewed changes
Copy link
Member

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the bug fix with e2e testing setup in 2 PRs? feel like they're not strongly bound together.

We also need to include need to include the test/e2e folder to prettier included files

@promer94 promer94 requested a review from huozhi May 25, 2022 02:57
@shuding shuding merged commit 3396d98 into vercel:main May 25, 2022
@promer94 promer94 deleted the yixuan/1974 branch March 5, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuding shuding shuding approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Beta feedback issue: isLoading and isValidating are changing indefinitely like in a loop in 2.0.0-beta.3
3 participants
@promer94 @shuding @huozhi