Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes webpack persistent caching in development and add test case for persistent caching #73697

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 9, 2024

What?

Fixes persistent caching for webpack in development

Add a test case for persistent caching on Turbopack and webpack.

Closes PACK-3635

Copy link
Member Author

sokra commented Dec 9, 2024

@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Tests Passed

@ijjk
Copy link
Member

ijjk commented Dec 9, 2024

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
buildDuration 19.7s 15.6s N/A
buildDurationCached 16.6s 12.5s N/A
nodeModulesSize 409 MB 409 MB ⚠️ +10.5 kB
nextStartRea..uration (ms) 473ms 473ms
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
1187-HASH.js gzip 50.2 kB 50.2 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.3 kB 5.3 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 232 B 235 B N/A
main-HASH.js gzip 33.8 kB 33.7 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Overall change 39.4 kB 39.4 kB
Client Pages
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
_app-HASH.js gzip 193 B 193 B
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB
edge-ssr-HASH.js gzip 265 B 265 B
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.44 kB 4.43 kB N/A
index-HASH.js gzip 268 B 268 B
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B
script-HASH.js gzip 397 B 397 B
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.59 kB 3.59 kB
Client Build Manifests
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
_buildManifest.js gzip 747 B 745 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
index.html gzip 524 B 523 B N/A
link.html gzip 538 B 538 B
withRouter.html gzip 520 B 520 B
Overall change 1.06 kB 1.06 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 203 kB 203 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
middleware-b..fest.js gzip 670 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31 kB 31 kB N/A
edge-runtime..pack.js gzip 844 B 844 B
Overall change 844 B 844 B
Next Runtimes
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
523-experime...dev.js gzip 322 B 322 B
523.runtime.dev.js gzip 314 B 314 B
app-page-exp...dev.js gzip 322 kB 322 kB
app-page-exp..prod.js gzip 127 kB 127 kB
app-page-tur..prod.js gzip 140 kB 140 kB
app-page-tur..prod.js gzip 135 kB 135 kB
app-page.run...dev.js gzip 312 kB 312 kB
app-page.run..prod.js gzip 122 kB 122 kB
app-route-ex...dev.js gzip 37.1 kB 37.1 kB
app-route-ex..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 25.1 kB 25.1 kB
app-route-tu..prod.js gzip 24.9 kB 24.9 kB
app-route.ru...dev.js gzip 38.7 kB 38.7 kB
app-route.ru..prod.js gzip 24.9 kB 24.9 kB
pages-api-tu..prod.js gzip 9.56 kB 9.56 kB
pages-api.ru...dev.js gzip 11.4 kB 11.4 kB
pages-api.ru..prod.js gzip 9.56 kB 9.56 kB
pages-turbo...prod.js gzip 21.3 kB 21.3 kB
pages.runtim...dev.js gzip 27 kB 27 kB
pages.runtim..prod.js gzip 21.3 kB 21.3 kB
server.runti..prod.js gzip 916 kB 916 kB
Overall change 2.35 MB 2.35 MB
build cache
vercel/next.js canary vercel/next.js sokra/persistent-caching-test-case Change
0.pack gzip 2.04 MB 2.03 MB N/A
index.pack gzip 145 kB 70.9 kB N/A
Overall change 0 B 0 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 4d02333

@sokra sokra changed the base branch from sokra/emit-collectibles-resolved to graphite-base/73697 December 9, 2024 18:43
@sokra sokra force-pushed the sokra/persistent-caching-test-case branch from 374a023 to 5201393 Compare December 9, 2024 18:44
@sokra sokra force-pushed the graphite-base/73697 branch from acf20f7 to 928c217 Compare December 9, 2024 18:44
@sokra sokra changed the base branch from graphite-base/73697 to canary December 9, 2024 18:44
@sokra sokra force-pushed the sokra/persistent-caching-test-case branch from 5201393 to 339e7dc Compare December 9, 2024 18:44
@sokra sokra force-pushed the sokra/persistent-caching-test-case branch from 339e7dc to 4d02333 Compare December 10, 2024 09:23
@sokra sokra requested a review from mischnic December 10, 2024 09:28
@sokra sokra changed the title add test case for persistent caching fixes webpack persistent caching in development and add test case for persistent caching Dec 10, 2024
@sokra sokra marked this pull request as ready for review December 10, 2024 09:33
@sokra sokra merged commit 21eb54a into canary Dec 10, 2024
114 checks passed
Copy link
Member Author

sokra commented Dec 10, 2024

Merge activity

  • Dec 10, 9:19 AM EST: A user merged this pull request with Graphite.

@sokra sokra deleted the sokra/persistent-caching-test-case branch December 10, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants