[Turbopack] change emit collectible to require ResolvedVc #73684

sokra · 2024-12-09T09:14:13Z

What?

The new backend require that emitted collectibles are resolved.
This changes the types to accept ResolvedVc instead of Vc to enforce that.

Closes PACK-3627

sokra · 2024-12-09T09:14:30Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

ijjk · 2024-12-09T09:25:49Z

Stats from current PR

Default Build (Increase detected ⚠️)

General

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
buildDuration	28.1s	23.7s	N/A
buildDurationCached	22.8s	20.8s	N/A
nodeModulesSize	409 MB	409 MB	N/A
nextStartRea..uration (ms)	565ms	565ms	✓

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
1187-HASH.js gzip	50.2 kB	50.2 kB	N/A
8276.HASH.js gzip	169 B	168 B	N/A
8377-HASH.js gzip	5.3 kB	5.3 kB	N/A
bccd1874-HASH.js gzip	53 kB	53 kB	N/A
framework-HASH.js gzip	57.5 kB	57.5 kB	N/A
main-app-HASH.js gzip	233 B	235 B	N/A
main-HASH.js gzip	33.8 kB	33.7 kB	N/A
webpack-HASH.js gzip	1.71 kB	1.71 kB	N/A
Overall change	0 B	0 B	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Overall change	39.4 kB	39.4 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
_app-HASH.js gzip	193 B	193 B	✓
_error-HASH.js gzip	193 B	193 B	✓
amp-HASH.js gzip	512 B	510 B	N/A
css-HASH.js gzip	343 B	342 B	N/A
dynamic-HASH.js gzip	1.84 kB	1.84 kB	✓
edge-ssr-HASH.js gzip	265 B	265 B	✓
head-HASH.js gzip	363 B	362 B	N/A
hooks-HASH.js gzip	393 B	392 B	N/A
image-HASH.js gzip	4.44 kB	4.43 kB	N/A
index-HASH.js gzip	268 B	268 B	✓
link-HASH.js gzip	2.35 kB	2.34 kB	N/A
routerDirect..HASH.js gzip	328 B	328 B	✓
script-HASH.js gzip	397 B	397 B	✓
withRouter-HASH.js gzip	323 B	326 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.59 kB	3.59 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
_buildManifest.js gzip	747 B	745 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
index.html gzip	524 B	524 B	✓
link.html gzip	539 B	539 B	✓
withRouter.html gzip	520 B	521 B	N/A
Overall change	1.06 kB	1.06 kB	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
edge-ssr.js gzip	128 kB	128 kB	N/A
page.js gzip	203 kB	203 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
middleware-b..fest.js gzip	670 B	670 B	✓
middleware-r..fest.js gzip	155 B	156 B	N/A
middleware.js gzip	31 kB	31 kB	N/A
edge-runtime..pack.js gzip	844 B	844 B	✓
Overall change	1.51 kB	1.51 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
523-experime...dev.js gzip	322 B	322 B	✓
523.runtime.dev.js gzip	314 B	314 B	✓
app-page-exp...dev.js gzip	322 kB	322 kB	✓
app-page-exp..prod.js gzip	127 kB	127 kB	✓
app-page-tur..prod.js gzip	140 kB	140 kB	✓
app-page-tur..prod.js gzip	135 kB	135 kB	✓
app-page.run...dev.js gzip	312 kB	312 kB	✓
app-page.run..prod.js gzip	122 kB	122 kB	✓
app-route-ex...dev.js gzip	37.1 kB	37.1 kB	✓
app-route-ex..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	25.1 kB	25.1 kB	✓
app-route-tu..prod.js gzip	24.9 kB	24.9 kB	✓
app-route.ru...dev.js gzip	38.7 kB	38.7 kB	✓
app-route.ru..prod.js gzip	24.9 kB	24.9 kB	✓
pages-api-tu..prod.js gzip	9.56 kB	9.56 kB	✓
pages-api.ru...dev.js gzip	11.4 kB	11.4 kB	✓
pages-api.ru..prod.js gzip	9.56 kB	9.56 kB	✓
pages-turbo...prod.js gzip	21.3 kB	21.3 kB	✓
pages.runtim...dev.js gzip	27 kB	27 kB	✓
pages.runtim..prod.js gzip	21.3 kB	21.3 kB	✓
server.runti..prod.js gzip	916 kB	916 kB	✓
Overall change	2.35 MB	2.35 MB	✓

build cache Overall increase ⚠️

	vercel/next.js canary	vercel/next.js sokra/emit-collectibles-resolved	Change
0.pack gzip	2.04 MB	2.04 MB	N/A
index.pack gzip	144 kB	146 kB	⚠️ +1.1 kB
Overall change	144 kB	146 kB	⚠️ +1.1 kB

Diff details

Diff for main-HASH.js

Diff too large to display

Commit: acf20f7

kdy1 · 2024-12-09T09:26:34Z

turbopack/crates/turbopack-ecmascript/src/parse.rs

@@ -462,6 +459,8 @@ async fn parse_file_content(
        // Assign the correct globals
        *g = globals;
    }
+    collector.emit().await?;
+    collector_parse.emit().await?;


Is this order correct?

It doesn't matter. Collectibles have no order

ijjk · 2024-12-09T09:28:40Z

Tests Passed

mischnic · 2024-12-09T10:56:43Z

turbopack/crates/turbopack-swc-utils/src/emitter.rs

+        for issue in issues {
+            issue.to_resolved().await?.emit();
+        }


This could happen in parallel? similar to try_join() (except there's no return result in this case)

It doesn't matter. The tasks are already scheduled by that. It only waits for completion

mischnic · 2024-12-09T11:22:28Z

The new test fails

FAIL test/e2e/persistent-caching/persistent-caching.test.ts (110.603 s)
  persistent-caching
    ✕ should persistent cache loaders (1887 ms)
    ✓ should allow to change files while stopped (80365 ms)

  ● persistent-caching › should persistent cache loaders

    page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:44911/pages", waiting until "load"

      282 |     opts?.beforePageLoad?.(page)
      283 |
    > 284 |     await page.goto(url, { waitUntil: 'load' })
          |                ^

sokra · 2024-12-09T18:43:24Z

Merge activity

Dec 9, 1:43 PM EST: A user merged this pull request with Graphite.

ijjk added created-by: Turbopack team PRs by the Turbopack team. Font (next/font) Related to Next.js Font Optimization. Turbopack Related to Turbopack with Next.js. labels Dec 9, 2024

sokra changed the title ~~change emit collectible to require ResolvedVc~~ [Turbopack] change emit collectible to require ResolvedVc Dec 9, 2024

sokra requested a review from kdy1 December 9, 2024 09:15

sokra marked this pull request as ready for review December 9, 2024 09:15

kdy1 reviewed Dec 9, 2024

View reviewed changes

kdy1 approved these changes Dec 9, 2024

View reviewed changes

change emit collectible to require ResolvedVc

89bda61

sokra force-pushed the sokra/emit-collectibles-resolved branch from 7f9f7e1 to 89bda61 Compare December 9, 2024 10:07

ijjk added the tests label Dec 9, 2024

mischnic reviewed Dec 9, 2024

View reviewed changes

update snapshots

acf20f7

sokra force-pushed the sokra/emit-collectibles-resolved branch from d57934a to acf20f7 Compare December 9, 2024 14:38

sokra mentioned this pull request Dec 9, 2024

fixes webpack persistent caching in development and add test case for persistent caching #73697

Merged

sokra merged commit 928c217 into canary Dec 9, 2024
112 checks passed

sokra deleted the sokra/emit-collectibles-resolved branch December 9, 2024 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Turbopack] change emit collectible to require ResolvedVc #73684

[Turbopack] change emit collectible to require ResolvedVc #73684

sokra commented Dec 9, 2024 •

edited by padmaia

Loading

sokra commented Dec 9, 2024 •

edited

Loading

ijjk commented Dec 9, 2024 •

edited

Loading

kdy1 Dec 9, 2024 •

edited

Loading

sokra Dec 9, 2024 •

edited

Loading

ijjk commented Dec 9, 2024 •

edited

Loading

mischnic Dec 9, 2024

sokra Dec 9, 2024

mischnic commented Dec 9, 2024

sokra commented Dec 9, 2024

[Turbopack] change emit collectible to require ResolvedVc #73684

[Turbopack] change emit collectible to require ResolvedVc #73684

Conversation

sokra commented Dec 9, 2024 • edited by padmaia Loading

What?

sokra commented Dec 9, 2024 • edited Loading

ijjk commented Dec 9, 2024 • edited Loading

Stats from current PR

kdy1 Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

sokra Dec 9, 2024 • edited Loading

Choose a reason for hiding this comment

ijjk commented Dec 9, 2024 • edited Loading

Tests Passed

mischnic Dec 9, 2024

Choose a reason for hiding this comment

sokra Dec 9, 2024

Choose a reason for hiding this comment

mischnic commented Dec 9, 2024

sokra commented Dec 9, 2024

Merge activity

sokra commented Dec 9, 2024 •

edited by padmaia

Loading

sokra commented Dec 9, 2024 •

edited

Loading

ijjk commented Dec 9, 2024 •

edited

Loading

kdy1 Dec 9, 2024 •

edited

Loading

sokra Dec 9, 2024 •

edited

Loading

ijjk commented Dec 9, 2024 •

edited

Loading