refactor(turbopack): Use ResolvedVc<T> for struct fields in extra crates
#73451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
kdy1
changed the title
ResolvedVc<T> for struct fields in extra crates
This was referenced Dec 3, 2024
kdy1
force-pushed
the
kdy1/resolved-vc-trivial
branch
from
baed0b1 to
7abf6e5
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-extras
branch
from
581a395 to
f69b0a2
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-trivial
branch
from
7abf6e5 to
41457b4
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-extras
branch
from
f69b0a2 to
710fa56
Compare
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| buildDuration | 27.6s | 24.1s | N/A |
| buildDurationCached | 23.3s | 20.8s | N/A |
| nodeModulesSize | 409 MB | 409 MB | N/A |
| nextStartRea..uration (ms) | 590ms | 574ms | N/A |
Client Bundles (main, webpack)
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| 1187-HASH.js gzip | 50.2 kB | 50.2 kB | N/A |
| 8276.HASH.js gzip | 169 B | 168 B | N/A |
| 8377-HASH.js gzip | 5.3 kB | 5.3 kB | N/A |
| bccd1874-HASH.js gzip | 53 kB | 53 kB | N/A |
| framework-HASH.js gzip | 57.5 kB | 57.5 kB | N/A |
| main-app-HASH.js gzip | 233 B | 234 B | N/A |
| main-HASH.js gzip | 33.8 kB | 33.7 kB | N/A |
| webpack-HASH.js gzip | 1.71 kB | 1.71 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 39.4 kB | 39.4 kB | ✓ |
| Overall change | 39.4 kB | 39.4 kB | ✓ |
Client Pages
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 193 B | 193 B | ✓ |
| _error-HASH.js gzip | 193 B | 193 B | ✓ |
| amp-HASH.js gzip | 513 B | 511 B | N/A |
| css-HASH.js gzip | 343 B | 342 B | N/A |
| dynamic-HASH.js gzip | 1.84 kB | 1.84 kB | N/A |
| edge-ssr-HASH.js gzip | 265 B | 265 B | ✓ |
| head-HASH.js gzip | 363 B | 362 B | N/A |
| hooks-HASH.js gzip | 393 B | 392 B | N/A |
| image-HASH.js gzip | 4.44 kB | 4.43 kB | N/A |
| index-HASH.js gzip | 268 B | 268 B | ✓ |
| link-HASH.js gzip | 2.35 kB | 2.34 kB | N/A |
| routerDirect..HASH.js gzip | 328 B | 328 B | ✓ |
| script-HASH.js gzip | 397 B | 397 B | ✓ |
| withRouter-HASH.js gzip | 323 B | 326 B | N/A |
| 1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
| Overall change | 1.75 kB | 1.75 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 746 B | 747 B | N/A |
| Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| index.html gzip | 524 B | 521 B | N/A |
| link.html gzip | 537 B | 537 B | ✓ |
| withRouter.html gzip | 520 B | 519 B | N/A |
| Overall change | 537 B | 537 B | ✓ |
Edge SSR bundle Size
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| edge-ssr.js gzip | 128 kB | 128 kB | N/A |
| page.js gzip | 203 kB | 203 kB | N/A |
| Overall change | 0 B | 0 B | ✓ |
Middleware size
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| middleware-b..fest.js gzip | 669 B | 665 B | N/A |
| middleware-r..fest.js gzip | 155 B | 156 B | N/A |
| middleware.js gzip | 31 kB | 31 kB | N/A |
| edge-runtime..pack.js gzip | 844 B | 844 B | ✓ |
| Overall change | 844 B | 844 B | ✓ |
Next Runtimes
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| 797-experime...dev.js gzip | 322 B | 322 B | ✓ |
| 797.runtime.dev.js gzip | 314 B | 314 B | ✓ |
| app-page-exp...dev.js gzip | 322 kB | 322 kB | ✓ |
| app-page-exp..prod.js gzip | 127 kB | 127 kB | ✓ |
| app-page-tur..prod.js gzip | 140 kB | 140 kB | ✓ |
| app-page-tur..prod.js gzip | 135 kB | 135 kB | ✓ |
| app-page.run...dev.js gzip | 312 kB | 312 kB | ✓ |
| app-page.run..prod.js gzip | 122 kB | 122 kB | ✓ |
| app-route-ex...dev.js gzip | 37.1 kB | 37.1 kB | ✓ |
| app-route-ex..prod.js gzip | 25.1 kB | 25.1 kB | ✓ |
| app-route-tu..prod.js gzip | 25.1 kB | 25.1 kB | ✓ |
| app-route-tu..prod.js gzip | 24.9 kB | 24.9 kB | ✓ |
| app-route.ru...dev.js gzip | 38.7 kB | 38.7 kB | ✓ |
| app-route.ru..prod.js gzip | 24.9 kB | 24.9 kB | ✓ |
| pages-api-tu..prod.js gzip | 9.56 kB | 9.56 kB | ✓ |
| pages-api.ru...dev.js gzip | 11.4 kB | 11.4 kB | ✓ |
| pages-api.ru..prod.js gzip | 9.56 kB | 9.56 kB | ✓ |
| pages-turbo...prod.js gzip | 21.3 kB | 21.3 kB | ✓ |
| pages.runtim...dev.js gzip | 27 kB | 27 kB | ✓ |
| pages.runtim..prod.js gzip | 21.3 kB | 21.3 kB | ✓ |
| server.runti..prod.js gzip | 916 kB | 916 kB | ✓ |
| Overall change | 2.35 MB | 2.35 MB | ✓ |
build cache Overall increase ⚠️
| vercel/next.js canary | vercel/next.js kdy1/resolved-vc-extras | Change | |
|---|---|---|---|
| 0.pack gzip | 2.03 MB | 2.03 MB | |
| index.pack gzip | 145 kB | 145 kB | |
| Overall change | 2.18 MB | 2.18 MB |
Diff details
Diff for main-HASH.js
Diff too large to display
kdy1
force-pushed
the
kdy1/resolved-vc-trivial
branch
2 times, most recently
from
5a91f16 to
5479021
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-extras
branch
from
710fa56 to
3fb1e4c
Compare
mischnic
approved these changes
Dec 5, 2024
kdy1
changed the base branch from
kdy1/resolved-vc-trivial
to
graphite-base/73451
kdy1
force-pushed
the
graphite-base/73451
branch
from
5479021 to
5232482
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-extras
branch
from
3fb1e4c to
2e94641
Compare
kdy1
force-pushed
the
kdy1/resolved-vc-extras
branch
from
2e94641 to
20b70e5
Compare
Tests Passed |
|
Something really did break the unit tests, but I can't see any problem in the diff |
kdy1
force-pushed
the
kdy1/resolved-vc-extras
branch
from
20b70e5 to
113bdb7
Compare
Merge activity
|
sokra
reviewed
Dec 8, 2024
Comment on lines
+851
to
859
| AnalyzeIssue::new( | ||
| IssueSeverity::Error.cell(), | ||
| source.ident(), | ||
| Vc::cell("unexpected top level await".into()), | ||
| StyledString::Text("top level await is only supported in ESM modules.".into()).cell(), | ||
| None, | ||
| Some(issue_source(*source, span)), | ||
| ) | ||
| .emit(); |
There was a problem hiding this comment.
This breaks persistent caching as only resolved cells are allows to be emitted.
There was a problem hiding this comment.
I'll check if inverting to make it resolved is possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PACK-3621