Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(turbopack): Use ResolvedVc<T> for struct fields in turbopack-core #73301

Merged
merged 12 commits into from
Dec 5, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 28, 2024

Closes PACK-3611

@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from c82527a to 66ade37 Compare November 28, 2024 06:07
@ijjk ijjk added the Turbopack Related to Turbopack with Next.js. label Nov 28, 2024
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-turbopack-css to kdy1/resolved-vc-next-api November 28, 2024 06:07
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 66ade37 to 502d00e Compare November 28, 2024 06:31
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-next-api to kdy1/resolved-vc-turbopack-css November 28, 2024 06:31
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from df70628 to 0e4d3b9 Compare November 28, 2024 07:11
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 502d00e to 4706684 Compare November 28, 2024 07:11
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 0e4d3b9 to eede930 Compare November 28, 2024 07:18
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 4706684 to 86d090c Compare November 28, 2024 07:18
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from eede930 to 2e80487 Compare November 28, 2024 07:27
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 86d090c to 7d560e0 Compare November 28, 2024 07:27
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 2e80487 to 735d870 Compare November 28, 2024 08:44
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 7d560e0 to 1320e33 Compare November 28, 2024 08:44
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 735d870 to 1d3b627 Compare November 28, 2024 09:04
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 1320e33 to fb227f9 Compare November 28, 2024 09:04
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 1d3b627 to 579c55d Compare November 28, 2024 09:13
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from fb227f9 to 9c2d74e Compare November 28, 2024 09:14
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 579c55d to 47ff248 Compare November 28, 2024 10:39
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 9c2d74e to cc96952 Compare November 28, 2024 10:40
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from 47ff248 to c6f9c94 Compare November 29, 2024 17:20
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from cc96952 to ad1f9f0 Compare November 29, 2024 17:20
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-css branch from c6f9c94 to 4092bbe Compare November 29, 2024 17:22
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from ad1f9f0 to 1d851de Compare November 29, 2024 17:22
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 61b5ac0 to 2d0108f Compare November 30, 2024 06:40
@kdy1 kdy1 changed the base branch from kdy1/resolved-vc-next-api-1 to graphite-base/73301 November 30, 2024 09:02
@bgw bgw changed the base branch from graphite-base/73301 to canary November 30, 2024 09:02
@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch 2 times, most recently from baf7669 to d555635 Compare November 30, 2024 09:03
@ijjk
Copy link
Member

ijjk commented Nov 30, 2024

Tests Passed

@kdy1 kdy1 requested a review from mischnic December 1, 2024 21:37
Copy link
Member Author

kdy1 commented Dec 4, 2024

Merge activity

  • Dec 4, 3:07 PM GMT+9: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@kdy1 kdy1 force-pushed the kdy1/resolved-vc-turbopack-core branch from 9a47841 to b764852 Compare December 5, 2024 03:34
@kdy1 kdy1 merged commit 2c75620 into canary Dec 5, 2024
107 of 112 checks passed
@kdy1 kdy1 deleted the kdy1/resolved-vc-turbopack-core branch December 5, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants