Fix i686 next-swc build due to int overflow #70995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztanner
approved these changes
Oct 9, 2024
This was referenced Oct 9, 2024
ijjk
added a commit
that referenced
this pull request
Oct 9, 2024
After #70995 investigated how much our windows 32 bit build is actually leveraged and it seems it is not at all. Also it seems Windows itself is [ending support for 32 bit](https://community.f-secure.com/total-en/kb/articles/29675-support-for-windows-10-32-bit-ending-on-september-30-2024#:~:text=Other%20Languages&text=F%2DSecure%20will%20stop%20supporting,a%20new%20version%20of%20Windows) arch so no reason for us to continue supporting it. Build and deploy workflow run: https://github.com/vercel/next.js/actions/runs/11260148483 x-ref: [slack thread](https://vercel.slack.com/archives/C04KC8A53T7/p1728431976293749)
kdy1
pushed a commit
that referenced
this pull request
Oct 10, 2024
This ensures we don't hit the max 32 bit int size on our i686 Windows build for `next-swc`. Validated fix against run here https://github.com/vercel/next.js/actions/runs/11245636466/job/31266030793 x-ref: https://github.com/vercel/next.js/actions/runs/11245312094/job/31265087281 x-ref: #69668
kdy1
pushed a commit
that referenced
this pull request
Oct 10, 2024
After #70995 investigated how much our windows 32 bit build is actually leveraged and it seems it is not at all. Also it seems Windows itself is [ending support for 32 bit](https://community.f-secure.com/total-en/kb/articles/29675-support-for-windows-10-32-bit-ending-on-september-30-2024#:~:text=Other%20Languages&text=F%2DSecure%20will%20stop%20supporting,a%20new%20version%20of%20Windows) arch so no reason for us to continue supporting it. Build and deploy workflow run: https://github.com/vercel/next.js/actions/runs/11260148483 x-ref: [slack thread](https://vercel.slack.com/archives/C04KC8A53T7/p1728431976293749)
kdy1
pushed a commit
that referenced
this pull request
Oct 10, 2024
This ensures we don't hit the max 32 bit int size on our i686 Windows build for `next-swc`. Validated fix against run here https://github.com/vercel/next.js/actions/runs/11245636466/job/31266030793 x-ref: https://github.com/vercel/next.js/actions/runs/11245312094/job/31265087281 x-ref: #69668
kdy1
pushed a commit
that referenced
this pull request
Oct 10, 2024
After #70995 investigated how much our windows 32 bit build is actually leveraged and it seems it is not at all. Also it seems Windows itself is [ending support for 32 bit](https://community.f-secure.com/total-en/kb/articles/29675-support-for-windows-10-32-bit-ending-on-september-30-2024#:~:text=Other%20Languages&text=F%2DSecure%20will%20stop%20supporting,a%20new%20version%20of%20Windows) arch so no reason for us to continue supporting it. Build and deploy workflow run: https://github.com/vercel/next.js/actions/runs/11260148483 x-ref: [slack thread](https://vercel.slack.com/archives/C04KC8A53T7/p1728431976293749)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we don't hit the max 32 bit int size on our i686 Windows build for
next-swc. Validated fix against run here https://github.com/vercel/next.js/actions/runs/11246045657/job/31267205387x-ref: https://github.com/vercel/next.js/actions/runs/11245312094/job/31265087281
x-ref: #69668