Skip to content

Commit

Permalink
Remove windows i686 next-swc build target (#71041)
Browse files Browse the repository at this point in the history
After #70995 investigated how much
our windows 32 bit build is actually leveraged and it seems it is not at
all. Also it seems Windows itself is [ending support for 32
bit](https://community.f-secure.com/total-en/kb/articles/29675-support-for-windows-10-32-bit-ending-on-september-30-2024#:~:text=Other%20Languages&text=F%2DSecure%20will%20stop%20supporting,a%20new%20version%20of%20Windows)
arch so no reason for us to continue supporting it.

Build and deploy workflow run:
https://github.com/vercel/next.js/actions/runs/11260148483
x-ref: [slack
thread](https://vercel.slack.com/archives/C04KC8A53T7/p1728431976293749)
  • Loading branch information
ijjk authored and kdy1 committed Oct 10, 2024
1 parent 23c91f6 commit 256ccb5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 42 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/build_and_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,6 @@ jobs:
exclude:
# only build the binaries we run automated tests against
# linux GNU x64
- settings:
target: ${{ needs.deploy-target.outputs.value == 'automated-preview' && 'i686-pc-windows-msvc' }}
- settings:
target: ${{ needs.deploy-target.outputs.value == 'automated-preview' && 'aarch64-apple-darwin' }}
- settings:
Expand Down Expand Up @@ -169,19 +167,6 @@ jobs:
turbo run build-native-release -vvv --env-mode loose --remote-cache-timeout 90 --summarize -- --target x86_64-pc-windows-msvc
target: 'x86_64-pc-windows-msvc'

- host:
- 'self-hosted'
- 'windows'
- 'x64'

# --env-mode loose is a breaking change required with turbo 2.x since Strict mode is now the default
# TODO: we should add the relevant envs later to to switch to strict mode
build: |
corepack enable
npm i -g "@napi-rs/cli@${NAPI_CLI_VERSION}" "turbo@${TURBO_VERSION}"
turbo run build-native-no-plugin-release -vvv --env-mode loose --remote-cache-timeout 90 --summarize -- --target i686-pc-windows-msvc
target: 'i686-pc-windows-msvc'

- host:
- 'self-hosted'
- 'windows'
Expand Down
3 changes: 0 additions & 3 deletions crates/napi/npm/win32-ia32-msvc/README.md

This file was deleted.

23 changes: 0 additions & 23 deletions crates/napi/npm/win32-ia32-msvc/package.json

This file was deleted.

1 change: 0 additions & 1 deletion scripts/install-native.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ import fsp from 'fs/promises'
'@next/swc-linux-x64-gnu': 'canary',
'@next/swc-linux-x64-musl': 'canary',
'@next/swc-win32-arm64-msvc': 'canary',
'@next/swc-win32-ia32-msvc': 'canary',
'@next/swc-win32-x64-msvc': 'canary',
},
packageManager,
Expand Down

0 comments on commit 256ccb5

Please sign in to comment.