Fix invalid source maps from terser-webpack-plugin #45423
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression in our source map generating which got lost in the big diff from the
src
folder restructure in #44405These invalid source maps broke plugins that attempted to leverage them like
@sentry/nextjs
which only attempts in a production environment https://github.com/getsentry/sentry-javascript/blob/15ec85bead77100413381be821f42841ae114f93/packages/nextjs/src/config/webpack.ts#L586For a regression test in a follow-up we will need to investigate a production test fixture with
@sentry/nextjs
although this requires a DSN be configured.This also ensures we setup
unhandledRejection
anduncaughtException
listeners during build so that we have proper stack information when these occur and the process isn't left hanging.This also moves the
extensionAlias
config from #44177 to an experimental config as it seems to cause conflicts with ESM packages that defineexports
in theirpackage.json
which can be considered a breaking change.Bug
fixes #number
contributing.md
Fixes: #45419
x-ref: slack thread