Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compatibility with ESM exports packages #1845

Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: Compatibility with ESM exports packages #1845

merged 1 commit into from
Feb 10, 2023

Conversation

ntucker
Copy link
Owner

@ntucker ntucker commented Feb 10, 2023

32bd97b introduced extensionAlias usage to make importing a local .js file resolve .tsx. However, this also made it not work for ESM packages with exports members.

This is likely a bug as it should fallback. However, by making it look for .js first it seems to work for both cases.

References:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 359 kB

ℹ️ View Unchanged
Filename Size
examples/typescript/dist/App.css 1.53 kB
examples/typescript/dist/App.js 78.6 kB
examples/typescript/dist/Error-index-tsx.chunk.js 234 B
examples/typescript/dist/GQL-index-tsx.chunk.js 1.36 kB
examples/typescript/dist/Home-__tests__-home-test-tsx.chunk.js 316 B
examples/typescript/dist/Home-__tests__-home-test-tsx.css 271 B
examples/typescript/dist/Home-index-tsx.css 263 B
examples/typescript/dist/index.html 272 B
examples/typescript/dist/Issues-index-tsx.chunk.js 2.4 kB
examples/typescript/dist/my.worker.js 158 B
examples/typescript/dist/polyfill.js 5.28 kB
examples/typescript/dist/Posts-__tests__-postList-test-tsx.chunk.js 2.05 kB
examples/typescript/dist/Posts-index-tsx.chunk.js 1.97 kB
examples/typescript/dist/Posts-PostCreate-tsx.chunk.js 1.65 kB
examples/typescript/dist/Posts-PostEdit-tsx.chunk.js 2.05 kB
examples/typescript/dist/Posts-PostForm-tsx.chunk.js 1.36 kB
examples/typescript/dist/Posts-PostListItem-tsx.chunk.js 1.59 kB
examples/typescript/dist/Posts-useForm-tsx.chunk.js 315 B
examples/typescript/dist/react.js 46.7 kB
examples/typescript/dist/redbox.chunk.js 10.7 kB
examples/typescript/dist/router.js 11.9 kB
examples/typescript/dist/Slow-index-tsx.chunk.js 410 B
examples/typescript/dist/src_pages_Home_index_tsx.chunk.js 4.83 kB
examples/typescript/dist/User-index-tsx.chunk.js 1.58 kB
examples/typescript/dist/vendors-node_modules_ant-design_icons_es_components_AntdIcon_js-node_modules_antd_es_list_ind-76ec18.chunk.js 34.8 kB
examples/typescript/dist/vendors-node_modules_ant-design_icons_es_components_AntdIcon_js-node_modules_path_path_js-nod-bae366.chunk.js 7.68 kB
examples/typescript/dist/vendors-node_modules_ant-design_icons_es_icons_InfoCircleOutlined_js-node_modules_ant-design_-564c9d.chunk.js 3.82 kB
examples/typescript/dist/vendors-node_modules_ant-design_icons_node_modules_ant-design_colors_dist_index_esm_js-node_m-da5397.chunk.js 7.77 kB
examples/typescript/dist/vendors-node_modules_ant-design_pro-layout_es_components_PageHeader_index_js.chunk.js 31.3 kB
examples/typescript/dist/vendors-node_modules_antd_es__util_statusUtils_js-node_modules_antd_es_config-provider_Disabl-3b8270.chunk.js 21.7 kB
examples/typescript/dist/vendors-node_modules_antd_es_button_index_js.chunk.js 5.86 kB
examples/typescript/dist/vendors-node_modules_antd_es_form_index_js-node_modules_antd_es_input_index_js.chunk.js 11.6 kB
examples/typescript/dist/vendors-node_modules_antd_es_grid_col_js-node_modules_antd_es_grid_row_js-node_modules_antd_n-b9a7aa.chunk.js 3.81 kB
examples/typescript/dist/vendors-node_modules_antd_es_input_TextArea_js.chunk.js 6.12 kB
examples/typescript/dist/vendors-node_modules_antd_es_typography_index_js.chunk.js 8.09 kB
examples/typescript/dist/vendors-node_modules_parse-link-header_index_js-node_modules_rest-hooks_react_lib_hooks_useLive_js.chunk.js 5.28 kB
examples/typescript/dist/vendors-node_modules_react-test-renderer_index_js.chunk.js 26.4 kB
examples/typescript/dist/vendors-node_modules_rest-hooks_endpoint_lib_endpoint_js-node_modules_rest-hooks_endpoint_lib-866236.chunk.js 1.72 kB
examples/typescript/dist/vendors-node_modules_rest-hooks_rest_lib_createResource_js.chunk.js 3.28 kB
examples/typescript/dist/webpack-runtime.js 2.13 kB

compressed-size-action

@ntucker ntucker merged commit 8c21961 into master Feb 10, 2023
@ntucker ntucker deleted the alias-fix branch February 10, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant