Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle telemetry not being available #44986

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 17, 2023

It seems there is an issue with yarn v3 where the exports for our traceGlobals may not be set as we expect causing calls to telemetry.record() to hang the build process since webpack stalls when an uncaught exception is thrown in a plugin.

Verified on the reproduction repo manually as well via yarn add next@https://files-620kx9vw0-vtest314-ijjk-testing.vercel.app/next-v13.1.3-canary.3.tgz

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Fixes: #44976

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 17, 2023
@ijjk ijjk marked this pull request as ready for review January 17, 2023 23:40
@ijjk ijjk merged commit 8f0acdf into canary Jan 18, 2023
@ijjk ijjk deleted the fix/missing-telemetry-yarn-v3 branch January 18, 2023 00:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next dev does not compile page as of Next 13.0.3-canary.4
1 participant