Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next dev does not compile page as of Next 13.0.3-canary.4 #44976

Closed
1 task done
markerikson opened this issue Jan 17, 2023 · 7 comments · Fixed by #44986
Closed
1 task done

next dev does not compile page as of Next 13.0.3-canary.4 #44976

markerikson opened this issue Jan 17, 2023 · 7 comments · Fixed by #44986
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team.

Comments

@markerikson
Copy link

markerikson commented Jan 17, 2023

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

Windows:

Operating System:
  Platform: win32
  Arch: x64
  Version: Windows 10 Pro
Binaries:
  Node: 18.11.0
  npm: N/A
  Yarn: N/A
  pnpm: N/A
Relevant packages:
  next: 13.1.3-canary.2
  eslint-config-next: N/A
  react: 0.0.0-experimental-e7d0053e6-20220325
  react-dom: 0.0.0-experimental-e7d0053e6-20220325

Linux:

Operating System:
  Platform: linux
  Arch: x64
  Version: #1 SMP Wed Nov 23 01:01:46 UTC 2022
Binaries:
  Node: 18.12.1
  npm: 8.19.2
  Yarn: 3.2.1
  pnpm: N/A
Relevant packages:
  next: 13.1.3-canary.2
  eslint-config-next: N/A
  react: 0.0.0-experimental-e7d0053e6-20220325
  react-dom: 0.0.0-experimental-e7d0053e6-20220325

Which area(s) of Next.js are affected? (leave empty if unsure)

No response

Link to the code that reproduces this issue

https://github.com/replayio/devtools/tree/feature/FE-1124-next-13-upgrade

To Reproduce

  1. Clone the Replay.io DevTools repo at https://github.com/replayio/devtools
  2. Check out branch feature/FE-1124-next-13-upgrade
  3. Run yarn to install all deps
  4. Run yarn dev to start the dev server
  5. Browse to http://localhost:8080/recording/reduxts-csb-2--be1a4568-6c84-474c-a9eb-3a0491a792d8 , which will attempt to compile page /recording/[[...id]]
  6. Observe that it does not finish compiling. There are no further progress updates.

Confirmed that this happens on both Windows and WSL Linux.

Describe the Bug

The Replay.io DevTools repo is currently on Next 12.1, and still uses Babel to do our JS compilation, as we had seen issues with Next+SWC sourcemaps (previously filed as #39878 ).

I attempted to upgrade our repo to Next 13.1.2 to see if the sourcemap issues were resolved. After installing 13.1.2, yarn build succeeded with Next configured to use either Babel or SWC for JS compilation. (Repo uses Babel by default because we have a .babelrc file. Renaming that to .babelrc.bak switches to SWC.)

However, when I tried to run yarn dev and load a page, Next started compiling our /recording/[[...id]] page, and never progressed further.

I bisected Next releases and confirmed that this behavior started with Next 13.0.3-canary.4. yarn dev runs okay with 13.0.3-canary.3, but the same freezing happens with 13.0.3-canary.4.

Looking at https://github.com/vercel/next.js/releases/tag/v13.0.3-canary.4 , the potentially relevant PRs could likely be:

Expected Behavior

yarn dev would successfully compile the page as usual

Which browser are you using? (if relevant)

Chrome 108, but not relevant

How are you deploying your application? (if relevant)

Local dev

@markerikson markerikson added the bug Issue was opened via the bug report template. label Jan 17, 2023
@leerob leerob added the linear: next Confirmed issue that is tracked by the Next.js team. label Jan 17, 2023
@ijjk
Copy link
Member

ijjk commented Jan 17, 2023

Hi, thanks for the detailed reproduction! Opened a patch for this here #44986 will update this thread when it's available on canary.

@markerikson
Copy link
Author

markerikson commented Jan 18, 2023

Hah, if it was telemetry, guess it must have been this PR that was the issue instead :)

Thank you for the extremely fast response on this!

@ijjk
Copy link
Member

ijjk commented Jan 18, 2023

Yeah that change surfaced it in initial compilation with yarn v3. The above patch is now available in v13.1.3-canary.4 of Next.js, please update and give it a try!

@markerikson
Copy link
Author

Awesome! I'm done for the day, but I'll give it another shot tomorrow.

@markerikson
Copy link
Author

Okay, confirmed that 13.1.3-canary.4 fixes the issue - thanks!

@ijjk
Copy link
Member

ijjk commented Jan 18, 2023

Great, thanks for confirming! 🚀

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. linear: next Confirmed issue that is tracked by the Next.js team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants